From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>
Subject: Re: [patchv2] Support .dwp with the name of symlinked binary file
Date: Mon, 16 Sep 2013 23:30:00 -0000 [thread overview]
Message-ID: <21047.38031.345197.307437@ruffy.mtv.corp.google.com> (raw)
In-Reply-To: <20130916190151.GA24936@host2.jankratochvil.net>
Jan Kratochvil writes:
> ISTM people want the directories normalized against any "../".
True.
OTOH, gdb can't know if/when there is an formal abstraction being implemented in symlinks (and thus when to terminate its realpath'ing). I can imagine providing some means to handle this, but we don't have to add it until there's a compelling need.
> IIUC you were proposing thin 'struct gdb_bfd *' wrapper around 'bfd *'.
It was a possibility to explore, nothing concrete.
> In the patchset above I have found we do not IMO need non-canonical filename
> from 'bfd *', it is enough to have non-canonical filename from 'objfile *'.
Sure.
> > And if we record the original file name we can always
> > get the realpath name,
>
> Calling gdb_realpath() dynamically is very expensive.
I wasn't suggesting that (in and of itself). :-)
[modulo, if one were to go in that direction one would implement the realpath cache, and then one might decide whether to still head in that direction]
next prev parent reply other threads:[~2013-09-16 23:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-05 13:18 Jan Kratochvil
2013-09-06 18:29 ` Doug Evans
2013-09-09 17:53 ` Tom Tromey
2013-09-09 22:59 ` Doug Evans
2013-09-16 19:01 ` Jan Kratochvil
2013-09-16 23:30 ` Doug Evans [this message]
2013-09-15 19:40 ` obsolete: " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=21047.38031.345197.307437@ruffy.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox