From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29027 invoked by alias); 16 Sep 2013 23:30:27 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 29018 invoked by uid 89); 16 Sep 2013 23:30:27 -0000 Received: from mail-qc0-f202.google.com (HELO mail-qc0-f202.google.com) (209.85.216.202) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 16 Sep 2013 23:30:27 +0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,RP_MATCHES_RCVD,SPF_SOFTFAIL autolearn=ham version=3.3.2 X-HELO: mail-qc0-f202.google.com Received: by mail-qc0-f202.google.com with SMTP id r5so584584qcx.1 for ; Mon, 16 Sep 2013 16:30:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:mime-version:content-type :content-transfer-encoding:message-id:date:to:cc:subject:in-reply-to :references; bh=clNulNHSyh2a74GaDvZJT9Jbh0WbpJ0O4Szf2mwXn68=; b=MSFaz7M+yZzFN2W3QbwbwmmlVlziM/MxuiktEnudvnJOT5jASfnboaFeqZAUZsc17x 7ZqzfP+VGevfMvtdj+wKFIHWqzgwdZh2Odand7qPjurXwA8TP1SEO5gnyU9mZJI1x1rA x6ZfrHJTnkdnmIkoLjVBIBUONLnn3SJ3XHxOLP+2iHC22lOEoHla+GUr48s+skg67WPa WgXjm8MdaM2yCfwgw55xNKcZvKCQOFoGidiAxqfCvQjIxpKi+hZrwy6cdAvC3navtRTU 7stjOYHT2klqqhp/8ZpkVPA1FkLiUUdg8YVq7oKHBjWpFnNutg0+xAPILSj9siGF8F+U iRdg== X-Gm-Message-State: ALoCoQlM760jczhsKEC1D22P9oHmd1fDp1lPhyljdoZ6BOGtklPswIMYbTgjLphhQSetZf6Rq8It3R8PT2I3MSztyQVSVDrnPKftONV++hKY0G4q5yN63bBbDRHkLAHCHxXrUAf0/8Q6t/6F6QNkgNQuGus1ZV2ovBEsIWCK8ntsQ/bjTtUWL6hJYPjiI5xOSJgIorTOLlDtzf7vhM9ckbra5BDsbrUcmw== X-Received: by 10.236.85.6 with SMTP id t6mr10828797yhe.37.1379374224450; Mon, 16 Sep 2013 16:30:24 -0700 (PDT) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id z45si2387479yha.7.1969.12.31.16.00.00 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Mon, 16 Sep 2013 16:30:24 -0700 (PDT) Received: from ruffy.mtv.corp.google.com (ruffy.mtv.corp.google.com [172.17.128.44]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id DE45531C193; Mon, 16 Sep 2013 16:30:23 -0700 (PDT) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <21047.38031.345197.307437@ruffy.mtv.corp.google.com> Date: Mon, 16 Sep 2013 23:30:00 -0000 To: Jan Kratochvil Cc: gdb-patches Subject: Re: [patchv2] Support .dwp with the name of symlinked binary file In-Reply-To: <20130916190151.GA24936@host2.jankratochvil.net> References: <20130905131839.GA8618@host2.jankratochvil.net> <20130916190151.GA24936@host2.jankratochvil.net> X-IsSubscribed: yes X-SW-Source: 2013-09/txt/msg00477.txt.bz2 Jan Kratochvil writes: > ISTM people want the directories normalized against any "../". True. OTOH, gdb can't know if/when there is an formal abstraction being implemented in symlinks (and thus when to terminate its realpath'ing). I can imagine providing some means to handle this, but we don't have to add it until there's a compelling need. > IIUC you were proposing thin 'struct gdb_bfd *' wrapper around 'bfd *'. It was a possibility to explore, nothing concrete. > In the patchset above I have found we do not IMO need non-canonical filename > from 'bfd *', it is enough to have non-canonical filename from 'objfile *'. Sure. > > And if we record the original file name we can always > > get the realpath name, > > Calling gdb_realpath() dynamically is very expensive. I wasn't suggesting that (in and of itself). :-) [modulo, if one were to go in that direction one would implement the realpath cache, and then one might decide whether to still head in that direction]