From: Doug Evans <dje@google.com>
To: Jan Kratochvil <jan.kratochvil@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [patchv2 6/11] New option 'set filename-display'
Date: Tue, 29 Jan 2013 21:35:00 -0000 [thread overview]
Message-ID: <20744.16555.106143.99469@ruffy2.mtv.corp.google.com> (raw)
In-Reply-To: <20130127223430.GG15252@host2.jankratochvil.net>
Jan Kratochvil writes:
> +/* See commentary in source.h. */
> +
> +const char *
> +symtab_to_filename (struct symtab *symtab)
> +{
> + if (filename_display_string == filename_display_basename)
> + return lbasename (symtab->filename);
> + else if (filename_display_string == filename_display_absolute)
> + return symtab_to_fullname (symtab);
> + else if (filename_display_string == filename_display_relative)
> + return symtab->filename;
> + else
> + internal_error (__FILE__, __LINE__, _("invalid filename_display_string"));
> +}
nit:
IWBN if this function were named symtab_to_filename_for_display or symtab_to_display_filename or some such.
next prev parent reply other threads:[~2013-01-29 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 22:34 Jan Kratochvil
2013-01-28 3:42 ` Eli Zaretskii
2013-01-29 21:35 ` Doug Evans [this message]
2013-02-01 20:55 ` Jan Kratochvil
2013-02-03 16:52 ` [commit] " Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20744.16555.106143.99469@ruffy2.mtv.corp.google.com \
--to=dje@google.com \
--cc=gdb-patches@sourceware.org \
--cc=jan.kratochvil@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox