From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16674 invoked by alias); 29 Jan 2013 21:35:47 -0000 Received: (qmail 16576 invoked by uid 22791); 29 Jan 2013 21:35:46 -0000 X-SWARE-Spam-Status: No, hits=-5.9 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,KHOP_RCVD_TRUST,KHOP_THREADED,RCVD_IN_DNSWL_LOW,RCVD_IN_HOSTKARMA_YE,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail-oa0-f74.google.com (HELO mail-oa0-f74.google.com) (209.85.219.74) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 21:35:41 +0000 Received: by mail-oa0-f74.google.com with SMTP id h2so200152oag.5 for ; Tue, 29 Jan 2013 13:35:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:mime-version:content-type:content-transfer-encoding :message-id:date:to:cc:subject:in-reply-to:references:x-mailer :x-gm-message-state; bh=QkvVxQX3mvi5d1oFcO4UsPbTAmUuFSFo5EFmZ/WTSH0=; b=pPf7tJF9Gg+RSybzdUVysOpE+2Hgk2gmv7JtKHxJz68UXi3YK4o4R0PXYDbmPI7+wY 8hRYKHCMt/dYwq+ZQSHZ+AADhcXUFO14RjuZMrGvj1u17kbzyaNkfKE/V8S0PJzPFNKJ sbaLDRflh6uJjxOWBEKb7VRVwKTpwl/HTBRzreWCs2ospz3E2/+pKNn3iFrQTwRgsfPC gIcE6T5vsHRGgtRpALilaDS2rsR7tM2dkthD8Lu4MrFJUL1jFXyA5a5xva63T6RMLRbA NR3NgPZiB6VGGG2PZTtGzczBjIYRZPp/YfahMbZUFtd1xPPLjz+FRYg237ni9wuVuIYN n0hw== X-Received: by 10.50.88.232 with SMTP id bj8mr2590925igb.1.1359495340710; Tue, 29 Jan 2013 13:35:40 -0800 (PST) Received: from corp2gmr1-1.hot.corp.google.com (corp2gmr1-1.hot.corp.google.com [172.24.189.92]) by gmr-mx.google.com with ESMTPS id j19si379884iga.2.2013.01.29.13.35.40 (version=TLSv1.1 cipher=AES128-SHA bits=128/128); Tue, 29 Jan 2013 13:35:40 -0800 (PST) Received: from ruffy2.mtv.corp.google.com (ruffy2.mtv.corp.google.com [172.17.128.107]) by corp2gmr1-1.hot.corp.google.com (Postfix) with ESMTP id C2D4131C107; Tue, 29 Jan 2013 13:35:39 -0800 (PST) From: Doug Evans MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <20744.16555.106143.99469@ruffy2.mtv.corp.google.com> Date: Tue, 29 Jan 2013 21:35:00 -0000 To: Jan Kratochvil Cc: gdb-patches@sourceware.org Subject: Re: [patchv2 6/11] New option 'set filename-display' In-Reply-To: <20130127223430.GG15252@host2.jankratochvil.net> References: <20130127223430.GG15252@host2.jankratochvil.net> X-Gm-Message-State: ALoCoQmPXTucFD9Mb5gqROhFJlkTq0R+sjIr6XK7S/+3Fu+Uo33WJTxBeCdIycgXb1iLMfat+3TrWxZJevnVbHJj0/wib41NTwUBSe310NvAvcTQGQgmuBlajjDwAuUp8CHu2B1Eh+pmMtAT1OyzAbkMtX9UkHfuRUJ+671NA3aBd0J0ZjtC7s4a6Aiet4CHPPJubBRsINTvDFvwjiQbS25qdPhWJgVzhg== X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2013-01/txt/msg00698.txt.bz2 Jan Kratochvil writes: > +/* See commentary in source.h. */ > + > +const char * > +symtab_to_filename (struct symtab *symtab) > +{ > + if (filename_display_string == filename_display_basename) > + return lbasename (symtab->filename); > + else if (filename_display_string == filename_display_absolute) > + return symtab_to_fullname (symtab); > + else if (filename_display_string == filename_display_relative) > + return symtab->filename; > + else > + internal_error (__FILE__, __LINE__, _("invalid filename_display_string")); > +} nit: IWBN if this function were named symtab_to_filename_for_display or symtab_to_display_filename or some such.