[PATCH 1/6] Add safe_target_to_connection_object

[Tom Tromey <tom@tromey.com>]

This adds safe_target_to_connection_object, a simple wrapper that lets
us remove a FIXME from the Python code.
---
 gdb/python/py-connection.c   | 17 ++++++++++++-----
 gdb/python/python-internal.h |  3 +++
 2 files changed, 15 insertions(+), 5 deletions(-)

diff --git a/gdb/python/py-connection.c b/gdb/python/py-connection.c
index 0b10ed2e594..809c60f9ce3 100644
--- a/gdb/python/py-connection.c
+++ b/gdb/python/py-connection.c
@@ -148,6 +148,17 @@ target_to_connection_object (process_stratum_target *target)
   return conn_obj;
 }
 
+/* See python-internal.h.  */
+
+gdbpy_ref<>
+safe_target_to_connection_object (process_stratum_target *target)
+{
+  gdbpy_ref<> result = target_to_connection_object (target);
+  if (result == nullptr)
+    throw gdb_python_exception ();
+  return result;
+}
+
 /* Return a list of gdb.TargetConnection objects, one for each currently
    active connection.  The returned list is in no particular order.  */
 
@@ -160,11 +171,7 @@ gdbpy_connections ()
     {
       gdb_assert (target != nullptr);
 
-      gdbpy_ref<> conn = target_to_connection_object (target);
-      /* FIXME: Python safety.  target_to_connection_object should
-	 throw on error.  */
-      if (conn == nullptr)
-	return nullptr;
+      gdbpy_ref<> conn = safe_target_to_connection_object (target);
       gdb_assert (conn.get () != Py_None);
 
       gdbpy_list_append (list, conn);
diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h
index 2e064107cbc..b57f3b0123d 100644
--- a/gdb/python/python-internal.h
+++ b/gdb/python/python-internal.h
@@ -607,6 +607,9 @@ PyObject *gdbpy_buffer_to_membuf (gdb::unique_xmalloc_ptr<gdb_byte> buffer,
 
 struct process_stratum_target;
 gdbpy_ref<> target_to_connection_object (process_stratum_target *target);
+/* A safe variant of target_to_connection_object; this throws on
+   error.  */
+gdbpy_ref<> safe_target_to_connection_object (process_stratum_target *target);
 gdbpy_ref<> gdbpy_connections ();
 
 const struct block *block_object_to_block (PyObject *obj);

-- 
2.49.0