From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 66u7GYuy22p10xAAWB0awg (envelope-from ) for ; Fri, 23 Oct 2026 15:16:27 -0400 Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (768-bit key; unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dgnFiCuP; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 441661E033; Fri, 23 Oct 2026 15:16:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 96FF81E023 for ; Fri, 23 Oct 2026 15:16:26 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F336E4BA2E0B for ; Fri, 23 Oct 2026 19:16:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F336E4BA2E0B Authentication-Results: sourceware.org; dkim=fail reason="signature verification failed" (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dgnFiCuP Received: from omta34.uswest2.a.cloudfilter.net (omta34.uswest2.a.cloudfilter.net [35.89.44.33]) by sourceware.org (Postfix) with ESMTPS id 8BE864BA2E09 for ; Fri, 23 Oct 2026 19:15:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8BE864BA2E09 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=tromey.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=tromey.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 8BE864BA2E09 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=35.89.44.33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792782951; cv=none; b=V+RRbMl95twicz58A9xdPcRUmZYCJya8Vam9LBKItnFkW+EH4pg2xGyJc9OylrgkRK+FLQU64kUL5z+vipXszKXLScyvAL5/oP9bqzdtcR112YIXNxVdS33pQcFNs9q9D1bkYUg8Ku80En+PxjVlPr3IYFBNaw0wIPO/7EKWZAA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1792782951; c=relaxed/simple; bh=yDNre4f8h3GXuELVboYPHnKnt8ozuOUf1RcYiiNxg5g=; h=DKIM-Signature:From:Date:Subject:MIME-Version:Message-Id:To; b=EUC03Y+AbL4hWKtbuJlgKL6HHwI5p6jwxpzYqvbY4/MhmAWLZ1pwP62OaZ1ADks/ct2TkOlicfq3N1ToUgEHLs+TOJfPqdxXnMNL3wXVu5z4mvR+D7imF1ZUn2fduZhGDjCTfXLHt0T9/AgbDsioZO6gyjGzsLQ0tB9AtRKhnoo= ARC-Authentication-Results: i=1; sourceware.org; dkim=policy (768-bit key, unprotected) header.d=tromey.com header.i=@tromey.com header.a=rsa-sha256 header.s=default header.b=dgnFiCuP reason="signing key too small" DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8BE864BA2E09 Received: from eig-obgw-6002b.ext.cloudfilter.net ([10.0.30.203]) by cmsmtp with ESMTPS id KJDmxbi05aC0UKKk2xDidi; Fri, 23 Oct 2026 19:15:50 +0000 Received: from box5379.bluehost.com ([162.241.216.53]) by cmsmtp with ESMTPS id KKk2x2fSVzqIpKKk2x5j4c; Fri, 23 Oct 2026 19:15:50 +0000 X-Authority-Analysis: v=2.4 cv=CcAI5Krl c=1 sm=1 tr=0 ts=6adbb266 a=ApxJNpeYhEAb1aAlGBBbmA==:117 a=ApxJNpeYhEAb1aAlGBBbmA==:17 a=IkcTkHD0fZMA:10 a=660iZSQnnn4A:10 a=ItBw4LHWJt0A:10 a=JeLGZyfbCzTzT1ZdTDMA:9 a=QEXdDO2ut3YA:10 a=DCx65vhANUyCzuf5D8fC:22 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=tromey.com; s=default; h=Cc:To:In-Reply-To:References:Message-Id: Content-Transfer-Encoding:Content-Type:MIME-Version:Subject:Date:From:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Unsubscribe-Post:List-Subscribe:List-Post:List-Owner:List-Archive; bh=7pAQDX9yC1xSO6f9YVpVuPHik6dSP0hiST1b4JAU9+4=; b=dgnFiCuPaH90UE7EO1pqNaKDvs wbGx1DtbkFPbC0uRcDDfuf16adaDbTBqm9zhNIDRx8QfeNiIZ9++mVssix1AHLLwsNYXP0iJnxESj iSJkEEgW2h4fBjKOmfjqzEhv8; Received: from 97-122-110-129.hlrn.qwest.net ([97.122.110.129]:59452 helo=[192.168.0.17]) by box5379.bluehost.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.100.1) (envelope-from ) id 1xKKk1-00000000DHL-2sbr; Fri, 23 Oct 2026 13:15:49 -0600 From: Tom Tromey Date: Fri, 23 Oct 2026 13:15:46 -0600 Subject: [PATCH 1/6] Add safe_target_to_connection_object MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <20261023-python-safety-fixmes-v1-1-055b9e1d237b@tromey.com> References: <20261023-python-safety-fixmes-v1-0-055b9e1d237b@tromey.com> In-Reply-To: <20261023-python-safety-fixmes-v1-0-055b9e1d237b@tromey.com> To: gdb-patches@sourceware.org Cc: Tom Tromey X-Mailer: b4 0.14.3 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - box5379.bluehost.com X-AntiAbuse: Original Domain - sourceware.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - tromey.com X-BWhitelist: no X-Source-IP: 97.122.110.129 X-Source-L: No X-Exim-ID: 1xKKk1-00000000DHL-2sbr X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: 97-122-110-129.hlrn.qwest.net ([192.168.0.17]) [97.122.110.129]:59452 X-Source-Auth: tom+tromey.com X-Email-Count: 2 X-Org: HG=bhshared;ORG=bluehost; X-Source-Cap: ZWx5bnJvYmk7ZWx5bnJvYmk7Ym94NTM3OS5ibHVlaG9zdC5jb20= X-Local-Domain: yes X-CMAE-Envelope: MS4xfDgGbInbAIxdqH0xtDfLx+hZmRB8XCesC2s/mPA8UTpsXtVzpxfys704+qij8vxCGtKeGg8+JCR1T/Q28Ob2O6bw6/poif05NRuJwryDZHAHfzsxnXJm i53w6pD90xGNcCDeuAFGyjJfxz1YYBqQ59TjHZ0NV1VmNoWruB4G7gin3LrjKCU1vcuO2ZQTNEgAuepouTAnRGPq2uu3H9Ze7Kw= X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org This adds safe_target_to_connection_object, a simple wrapper that lets us remove a FIXME from the Python code. --- gdb/python/py-connection.c | 17 ++++++++++++----- gdb/python/python-internal.h | 3 +++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/gdb/python/py-connection.c b/gdb/python/py-connection.c index 0b10ed2e594..809c60f9ce3 100644 --- a/gdb/python/py-connection.c +++ b/gdb/python/py-connection.c @@ -148,6 +148,17 @@ target_to_connection_object (process_stratum_target *target) return conn_obj; } +/* See python-internal.h. */ + +gdbpy_ref<> +safe_target_to_connection_object (process_stratum_target *target) +{ + gdbpy_ref<> result = target_to_connection_object (target); + if (result == nullptr) + throw gdb_python_exception (); + return result; +} + /* Return a list of gdb.TargetConnection objects, one for each currently active connection. The returned list is in no particular order. */ @@ -160,11 +171,7 @@ gdbpy_connections () { gdb_assert (target != nullptr); - gdbpy_ref<> conn = target_to_connection_object (target); - /* FIXME: Python safety. target_to_connection_object should - throw on error. */ - if (conn == nullptr) - return nullptr; + gdbpy_ref<> conn = safe_target_to_connection_object (target); gdb_assert (conn.get () != Py_None); gdbpy_list_append (list, conn); diff --git a/gdb/python/python-internal.h b/gdb/python/python-internal.h index 2e064107cbc..b57f3b0123d 100644 --- a/gdb/python/python-internal.h +++ b/gdb/python/python-internal.h @@ -607,6 +607,9 @@ PyObject *gdbpy_buffer_to_membuf (gdb::unique_xmalloc_ptr buffer, struct process_stratum_target; gdbpy_ref<> target_to_connection_object (process_stratum_target *target); +/* A safe variant of target_to_connection_object; this throws on + error. */ +gdbpy_ref<> safe_target_to_connection_object (process_stratum_target *target); gdbpy_ref<> gdbpy_connections (); const struct block *block_object_to_block (PyObject *obj); -- 2.49.0