[pushed] [gdb/testsuite] Check using_fission in allow_debuginfod_tests

[pushed] [gdb/testsuite] Check using_fission in allow_debuginfod_tests

[Tom de Vries]

With test-case gdb.debuginfod/fetch_src_and_symbols.exp and target board
dwarf5-fission-debug-types I run into:
...
(gdb) list 27
warning: 22     tmp-fetch_src_and_symbols.c: No such file or directory
(gdb) FAIL: $exp: local_url: list 27
...

The problem is that the test-case expects to start from a point where the
executable contains all the debug info, and when using fission that's not
the case.

We'd like to test fission in combination with debuginfod, but currently that's
not supported by debuginfod [1].

Fix this by skipping debuginfod test-cases when using fission.

Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=34751

[1] https://sourceware.org/bugzilla/show_bug.cgi?id=32184
---
 gdb/testsuite/lib/debuginfod-support.exp | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/gdb/testsuite/lib/debuginfod-support.exp b/gdb/testsuite/lib/debuginfod-support.exp
index 66b4098d4f9..1d11c5bea8b 100644
--- a/gdb/testsuite/lib/debuginfod-support.exp
+++ b/gdb/testsuite/lib/debuginfod-support.exp
@@ -33,6 +33,22 @@ proc allow_debuginfod_tests {} {
 	return false
     }
 
+    if {[using_fission]} {
+	# Debuginfod test-cases tend to split off debuginfo and move it to a
+	# place where gdb can't find it, but debuginfod can.
+	#
+	# Fission is another way to split off debuginfo, in the sense that only
+	# the skeleton units stay in the executable.  We'd like to test that
+	# debuginfod can serve .dwo or .dwp files, but that's currently not
+	# supported (PR debuginfod/32184).
+	#
+	# Return false because most debuginfod test-cases assume one
+	# particular type of split-off debuginfo.  There are a few that don't,
+	# but allowing those to run with fission doesn't actually test the
+	# fission+debuginfod behavior that we want to test.
+	return false
+    }
+
     # Skip testing if gdb was not configured with debuginfod.
     #
     # If GDB is built with ASan, it warns that some signal handlers

base-commit: 60e638ccd7de0776e72cae0cdcf7cc79b658cc95
-- 
2.51.0