[PATCH v4 0/1] Fix block filter heuristic in linespec to preserve distinct code paths

[Klaus Gerlicher <klaus.gerlicher@intel.com>]

From: "Gerlicher, Klaus" <klaus.gerlicher@intel.com>

Hi all, hi Christina, Luis,

thanks for your reviews and feedback.

This is V4 of the relax block filter patch, addressing review feedback
on V3.

V3 is here:

https://inbox.sourceware.org/gdb-patches/SN7PR11MB7638BE2D9E02DC0ED9BC901889DC2@SN7PR11MB7638.namprd11.prod.outlook.com/

- amd64_insn_branch_target now reuses amd64_get_insn_details
- added self-test coverage for the amd64 branch-target decoder
- simplified the set/show linespec-extended-block-filter help text:
- testsuite cleanups

No changes to the aarch64 parts, which Luis already reviewed.

If I may ask again, I did not find any documentation on the original heuristic
in GDB.texinfo and so I also did not try to add anything there. I'm also
not sure where we would put such description. If anyone could point
me where to put it, I would love to add some documentation there
since things are getting more complicated now.

Thanks,
Klaus

Gerlicher, Klaus (1):
  gdb/linespec: relax block filter to preserve distinct code paths

 gdb/NEWS                                      |  11 +
 gdb/aarch64-tdep.c                            |  91 ++++++
 gdb/amd64-tdep.c                              | 121 ++++++++
 gdb/arch-utils.c                              |  10 +
 gdb/arch-utils.h                              |   1 +
 gdb/arch/aarch64-insn.c                       |  23 ++
 gdb/arch/aarch64-insn.h                       |   2 +
 gdb/gdbarch-gen.c                             |  59 +++-
 gdb/gdbarch-gen.h                             |  16 +
 gdb/gdbarch_components.py                     |  18 ++
 gdb/linespec.c                                | 148 ++++++++-
 .../gdb.linespec/block-filter-cases.c         | 126 ++++++++
 .../gdb.linespec/block-filter-cases.exp       | 290 ++++++++++++++++++
 13 files changed, 911 insertions(+), 5 deletions(-)
 create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.c
 create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.exp

-- 
2.34.1

________________________________________
Intel Deutschland GmbH 

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany 

Tel: +49 (89) 99143-0 

www.intel.de 

Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman

Chairperson of the Supervisory Board: Sonja Pierer

Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.