From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pwBpFpOQs2oBsDYAWB0awg (envelope-from ) for ; Wed, 23 Sep 2026 04:40:51 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Xoe3tgQs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 381461E033; Wed, 23 Sep 2026 04:40:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8CD731E033 for ; Wed, 23 Sep 2026 04:40:48 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 135734BB24DF for ; Wed, 23 Sep 2026 08:40:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 135734BB24DF Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Xoe3tgQs Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.6]) by sourceware.org (Postfix) with ESMTPS id B03CC4B99F7B for ; Wed, 23 Sep 2026 08:40:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B03CC4B99F7B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=intel.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B03CC4B99F7B Authentication-Results: sourceware.org; arc=none smtp.remote-ip=192.198.163.6 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790152819; cv=none; b=pJAClnm0IFCHX7cul8iF2Voo5XMjuWDAGc79nhC3R+pUr6aEXfket9qtNXQgggdwpyqWzqyjmb9qYpBaruM8RinEf1jfM9iobHVpnxCS/3e6mfNlXg25CMdiTIo3R2e3qPqsfu6Ltob/LBLReW7jF8OTMNC862kuutSjiLa2OH4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1790152819; c=relaxed/simple; bh=GureJ0k0OfRgg0NyW7QNZep619c5YAsK5zYW+Q3pfYo=; h=DKIM-Signature:From:To:Subject:Date:Message-Id:MIME-Version; b=g9quwZ1yPdi43ByDTuVzwZ1ORijlw+QMvsHUJJXuR1zXe14C6qxfNW4FGmjUOKFF6gTXvlBCabMFkjxe4kXnYm28dvqXe0uHOeYcAR4sMG60Ilx5nYhEq0DSeezV0KaDueE6LjuduLP0Ubs0lVLzUx97XnBtPRpNzGcXiUnkoU8= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=Xoe3tgQs DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B03CC4B99F7B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1790152819; x=1821688819; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GureJ0k0OfRgg0NyW7QNZep619c5YAsK5zYW+Q3pfYo=; b=Xoe3tgQsPksO1ubnhu5inPTkPjyDuc/B6c4lcGhkmHb9umKjuhxgKQsA 4MBP+vXAGwUe7+F+lz19J8n4Vn9Ibw6L7eLuAnSMVzCTGhUcxy+YCLXdC VuYSKGTvBQ8racZsDxWkLA35TVdSn9FaOiP+4tt+DROFD4+dHJ+QlogiY SxJouNonnCIO7BBka+LJnztKQYhY+yCucQidxI7zYhBfWvlTxn7G+f/Jt ftMGKg6Xr65vDoLMXqmBnzPUSDz+Fg+kZWsap4UlaNw37EegIbJKhubsP VATBSB0S6bdZS26P7VNpzKbL5Qinau/qyBJYoMF+YrOsTLjLY5u70LeYZ g==; X-CSE-ConnectionGUID: /N76M0FpTm+f6sQZ96nKsQ== X-CSE-MsgGUID: yU+FXMFcT7qzVb3se5fBHA== X-IronPort-AV: E=McAfee;i="6800,10657,11913"; a="1317811" X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="1317811" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa116.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 01:40:17 -0700 X-CSE-ConnectionGUID: GWiFI5GGSHuImRkjxiynog== X-CSE-MsgGUID: d+CeNqEPRB6lJTUMawtzWg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.27,118,1787036400"; d="scan'208";a="281592667" Received: from gkdg2frd2754.igk.intel.com (HELO localhost) ([10.211.179.243]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Sep 2026 01:40:16 -0700 From: Klaus Gerlicher To: gdb-patches@sourceware.org Cc: christina.joos@intel.com, luis.machado.foss@gmail.com Subject: [PATCH v4 0/1] Fix block filter heuristic in linespec to preserve distinct code paths Date: Wed, 23 Sep 2026 08:40:12 +0000 Message-Id: <20260923084013.419968-1-klaus.gerlicher@intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org From: "Gerlicher, Klaus" Hi all, hi Christina, Luis, thanks for your reviews and feedback. This is V4 of the relax block filter patch, addressing review feedback on V3. V3 is here: https://inbox.sourceware.org/gdb-patches/SN7PR11MB7638BE2D9E02DC0ED9BC901889DC2@SN7PR11MB7638.namprd11.prod.outlook.com/ - amd64_insn_branch_target now reuses amd64_get_insn_details - added self-test coverage for the amd64 branch-target decoder - simplified the set/show linespec-extended-block-filter help text: - testsuite cleanups No changes to the aarch64 parts, which Luis already reviewed. If I may ask again, I did not find any documentation on the original heuristic in GDB.texinfo and so I also did not try to add anything there. I'm also not sure where we would put such description. If anyone could point me where to put it, I would love to add some documentation there since things are getting more complicated now. Thanks, Klaus Gerlicher, Klaus (1): gdb/linespec: relax block filter to preserve distinct code paths gdb/NEWS | 11 + gdb/aarch64-tdep.c | 91 ++++++ gdb/amd64-tdep.c | 121 ++++++++ gdb/arch-utils.c | 10 + gdb/arch-utils.h | 1 + gdb/arch/aarch64-insn.c | 23 ++ gdb/arch/aarch64-insn.h | 2 + gdb/gdbarch-gen.c | 59 +++- gdb/gdbarch-gen.h | 16 + gdb/gdbarch_components.py | 18 ++ gdb/linespec.c | 148 ++++++++- .../gdb.linespec/block-filter-cases.c | 126 ++++++++ .../gdb.linespec/block-filter-cases.exp | 290 ++++++++++++++++++ 13 files changed, 911 insertions(+), 5 deletions(-) create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.c create mode 100644 gdb/testsuite/gdb.linespec/block-filter-cases.exp -- 2.34.1 ________________________________________ Intel Deutschland GmbH Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany Tel: +49 (89) 99143-0 www.intel.de Managing Directors: Candice Moore, Jeffrey Schneiderman, Ramachandran Sitaraman Chairperson of the Supervisory Board: Sonja Pierer Registered Seat: Munich Commercial Register B: Amtsgericht Munich HRB 186928 This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.