From: Matthieu Longo <matthieu.longo@arm.com>
To: <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
Matthieu Longo <matthieu.longo@arm.com>
Subject: [PATCH v3 3/8] gdb/linux: style filenames in /proc warning messages
Date: Tue, 22 Sep 2026 14:50:45 +0100 [thread overview]
Message-ID: <20260922135050.236941-4-matthieu.longo@arm.com> (raw)
In-Reply-To: <20260922135050.236941-1-matthieu.longo@arm.com>
Use filename styling for the paths printed by warning messages in
linux_info_proc and linux_vsyscall_range_raw.
Replace the plain '%s' formatting with '%ps' and styled_string using
file_name_style, making these warnings consistent with other diagnostics
that display filenames.
Suggested-By: Andrew Burgess <aburgess@redhat.com>
---
gdb/linux-tdep.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index 799117a6d1b..bd4c1d5540f 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -932,7 +932,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
gdb_printf ("cmdline = '%s'\n", buffer);
}
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (cwd_f)
{
@@ -942,7 +943,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
if (contents.has_value ())
gdb_printf ("cwd = '%s'\n", contents->c_str ());
else
- warning (_("unable to read link '%s'"), filename);
+ warning (_("unable to read link '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (environ_f)
{
@@ -966,7 +968,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
}
}
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (exe_f)
{
@@ -976,7 +979,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
if (contents.has_value ())
gdb_printf ("exe = '%s'\n", contents->c_str ());
else
- warning (_("unable to read link '%s'"), filename);
+ warning (_("unable to read link '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (mappings_f)
{
@@ -1021,7 +1025,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
}
}
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (status_f)
{
@@ -1031,7 +1036,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
if (status)
gdb_puts (status.get ());
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
if (stat_f)
{
@@ -1167,7 +1173,8 @@ linux_info_proc (struct gdbarch *gdbarch, const char *args,
#endif
}
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
}
}
@@ -2923,7 +2930,8 @@ linux_vsyscall_range_raw (struct gdbarch *gdbarch, struct mem_range *range)
}
}
else
- warning (_("unable to open /proc file '%s'"), filename);
+ warning (_("unable to open /proc file '%ps'"),
+ styled_string (file_name_style.style (), filename));
return false;
}
--
2.55.0
next prev parent reply other threads:[~2026-09-22 13:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 13:50 [PATCH v3 0/8] gdb: introduce file_reader_t to read procfs files Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 1/8] gdb support: add gdb::ranges::replace algorithm Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 2/8] gdb/linux: remove redundant struct prefixes from smaps_data Matthieu Longo
2026-09-22 13:50 ` Matthieu Longo [this message]
2026-09-22 13:50 ` [PATCH v3 4/8] gdbsupport: add extract_next_field helper Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 5/8] gdb/linux: refactor /proc mapping parsing to use array_view Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 6/8] gdb: introduce helper class target_file_reader Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 7/8] gdb/linux-tdep: use target_file_reader for procfs parsing Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 8/8] gdb/linux-tdep: remove legacy parse_smaps_data overload Matthieu Longo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922135050.236941-4-matthieu.longo@arm.com \
--to=matthieu.longo@arm.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox