From: Matthieu Longo <matthieu.longo@arm.com>
To: <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
Matthieu Longo <matthieu.longo@arm.com>,
Christina Joos <christina.joos@intel.com>
Subject: [PATCH v3 2/8] gdb/linux: remove redundant struct prefixes from smaps_data
Date: Tue, 22 Sep 2026 14:50:44 +0100 [thread overview]
Message-ID: <20260922135050.236941-3-matthieu.longo@arm.com> (raw)
In-Reply-To: <20260922135050.236941-1-matthieu.longo@arm.com>
Remove the redundant 'struct' prefix from uses of smaps_data in
linux-tdep.c. In C++, the structure name can be used directly as
a type name.
Suggested-By: Christina Joos <christina.joos@intel.com>
---
gdb/linux-tdep.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/gdb/linux-tdep.c b/gdb/linux-tdep.c
index 4f6910694d5..799117a6d1b 100644
--- a/gdb/linux-tdep.c
+++ b/gdb/linux-tdep.c
@@ -1551,7 +1551,7 @@ parse_smaps_key_value (const char *keyword, const char *line,
DATA is the contents of the smaps file. The parsed contents are stored
into the SMAPS vector. */
-static std::vector<struct smaps_data>
+static std::vector<smaps_data>
parse_smaps_data (const char *data,
const std::string &maps_filename)
{
@@ -1561,7 +1561,7 @@ parse_smaps_data (const char *data,
line = strtok_r ((char *) data, "\n", &t);
- std::vector<struct smaps_data> smaps;
+ std::vector<smaps_data> smaps;
while (line != NULL)
{
@@ -1673,7 +1673,7 @@ parse_smaps_data (const char *data,
}
}
/* Save the smaps entry to the vector. */
- struct smaps_data map;
+ smaps_data map;
map.start_address = m.addr;
map.end_address = m.endaddr;
@@ -1716,7 +1716,7 @@ linux_process_address_in_memtag_page (CORE_ADDR address)
return false;
/* Parse the contents of smaps into a vector. */
- std::vector<struct smaps_data> smaps
+ std::vector<smaps_data> smaps
= parse_smaps_data (data.get (), smaps_file);
for (const smaps_data &map : smaps)
@@ -1812,10 +1812,10 @@ linux_find_memory_regions_full (struct gdbarch *gdbarch,
}
/* Parse the contents of smaps into a vector. */
- std::vector<struct smaps_data> smaps
+ std::vector<smaps_data> smaps
= parse_smaps_data (data.get (), maps_filename);
- for (const struct smaps_data &map : smaps)
+ for (const smaps_data &map : smaps)
{
/* Invoke the callback function to create the corefile segment. */
if (should_dump_mapping_p (filterflags, map))
--
2.55.0
next prev parent reply other threads:[~2026-09-22 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-22 13:50 [PATCH v3 0/8] gdb: introduce file_reader_t to read procfs files Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 1/8] gdb support: add gdb::ranges::replace algorithm Matthieu Longo
2026-09-22 13:50 ` Matthieu Longo [this message]
2026-09-22 13:50 ` [PATCH v3 3/8] gdb/linux: style filenames in /proc warning messages Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 4/8] gdbsupport: add extract_next_field helper Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 5/8] gdb/linux: refactor /proc mapping parsing to use array_view Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 6/8] gdb: introduce helper class target_file_reader Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 7/8] gdb/linux-tdep: use target_file_reader for procfs parsing Matthieu Longo
2026-09-22 13:50 ` [PATCH v3 8/8] gdb/linux-tdep: remove legacy parse_smaps_data overload Matthieu Longo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260922135050.236941-3-matthieu.longo@arm.com \
--to=matthieu.longo@arm.com \
--cc=aburgess@redhat.com \
--cc=christina.joos@intel.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox