From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Remove gdbserver_windows_process::attaching
Date: Wed, 2 Sep 2026 09:42:41 -0600 [thread overview]
Message-ID: <20260902154241.3495154-1-tromey@adacore.com> (raw)
Nothing uses the field gdbserver_windows_process::attaching. This
patch removes it.
---
gdbserver/win32-low.cc | 6 ------
gdbserver/win32-low.h | 2 --
2 files changed, 8 deletions(-)
diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc
index 13c14a7c69f..5c4505cdaf8 100644
--- a/gdbserver/win32-low.cc
+++ b/gdbserver/win32-low.cc
@@ -517,9 +517,6 @@ win32_process_target::create_inferior (const char *program,
DWORD err;
char *args = (char *) program_args.c_str ();
- /* win32_wait needs to know we're not attaching. */
- windows_process.attaching = 0;
-
if (!program)
error (_("No executable specified, specify executable to debug.\n"));
@@ -609,8 +606,6 @@ win32_process_target::attach (unsigned long pid)
{
DebugSetProcessKillOnExit (FALSE);
- /* win32_wait needs to know we're attaching. */
- windows_process.attaching = 1;
do_initial_child_stuff (h, pid, 1);
return 0;
}
@@ -988,7 +983,6 @@ get_child_debug_event (DWORD *continue_status,
/* Check if GDB sent us an interrupt request. */
check_remote_input_interrupt_request ();
- windows_process.attaching = 0;
{
process_info *proc = find_process_pid (windows_process.process_id);
for (thread_info &thread : proc->thread_list ())
diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h
index 439adb84bc2..a7ef8233321 100644
--- a/gdbserver/win32-low.h
+++ b/gdbserver/win32-low.h
@@ -187,8 +187,6 @@ struct gdbserver_windows_process : public windows_nat::windows_process_info
void fill_thread_context (windows_nat::windows_thread_info *th) override;
- int attaching = 0;
-
/* A status that hasn't been reported to the core yet, and so
win32_wait should return it next, instead of fetching the next
debug event off the win32 API. */
base-commit: 49c379f8c2f8ff888b621b4a070dc1976b942577
--
2.55.0
next reply other threads:[~2026-09-02 15:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 15:42 Tom Tromey [this message]
2026-09-03 11:19 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260902154241.3495154-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox