From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ecfkCA1EmGrJIB8AWB0awg (envelope-from ) for ; Wed, 02 Sep 2026 11:43:09 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PB2pgluX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 1FB651E166; Wed, 02 Sep 2026 11:43:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 581841E033 for ; Wed, 02 Sep 2026 11:43:08 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C816A4BAE7F9 for ; Wed, 2 Sep 2026 15:43:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C816A4BAE7F9 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PB2pgluX Received: from mail-ot1-x32e.google.com (mail-ot1-x32e.google.com [IPv6:2607:f8b0:4864:20::32e]) by sourceware.org (Postfix) with ESMTPS id 89FDA4BAE7C8 for ; Wed, 2 Sep 2026 15:42:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 89FDA4BAE7C8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 89FDA4BAE7C8 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::32e ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788363764; cv=none; b=GDfQvAfnEO38DxH3B9WGX8QmqM1mqJZp9YDsa1mcLeooB5z5B4x10uX9Gq4d2aoqhz5o91uPHC8QxX+RrfXLVJ1GHqZt0xyB1T6FouyDG9TgpPuAUCUv5iZMjM41cJVhNfERGz3Cyk3TrGeYIRd3VnAfMbVXdaOwL70cDYm/L3E= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788363764; c=relaxed/simple; bh=DrFG7aEIfQOEBnqo8CnW5Qz4cs4Zf4tey/Uj50vfBpc=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=vGv686NHfKha0iBh4w/3jnWyn/EdjeaSUAI/d8tvqepVriksgmffF+GW9mt/yVLELOK3GBobSftfCi3c1SCh5Qp1FDlmnlBX+CxXLF2tUSrPPKxhrogKo71FjQIXxvgoJDdgH7mkKxQ7F3dKal5BCbq1QM76KYLa4v6N6ZTPfZk= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=PB2pgluX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89FDA4BAE7C8 Received: by mail-ot1-x32e.google.com with SMTP id 46e09a7af769-7f18c0e03e3so646252a34.2 for ; Wed, 02 Sep 2026 08:42:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1788363764; x=1788968564; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=tG2S7uZrnzeuThosRhKkr+WaPNLCFIKPXa4a6XTtBWY=; b=PB2pgluXBsY39Il548jojIVTImvK06l2+4E/NrQF9GcJIVYP4mc+u+a1On81xjZssF RrzClxIyp4DlKDcRFsu06HA0GJv+PUaZLb+Pl3eH50OoCDL780EsvIlewgeOrKwjZo0f tUEG52G3L4cJUzA8fVRNDiaMtwyT6DNVJg8JkuJ007fKzD+gFvQElJcQewP02tFJE038 rqqN3i1TEbyE6EEoYWi9Pk2dGYf3KditXuPiZhjlv8hVSzPJo9tssYXKJporMH+0uJNk P81Czpduzv3r4FDWlyolK6s9THQ7OTfjA12ioorSem/csJSiZm7Ye0q6j3doVylBpfWp qBAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788363764; x=1788968564; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=tG2S7uZrnzeuThosRhKkr+WaPNLCFIKPXa4a6XTtBWY=; b=LHgNrCZL7SFjC8x7AQ7w4sI+nJxbvj3Lzjp+MCfT9CItiGhlfxoYroHTUpbU+G4CQe KhSPeGJgcOXh+mIJj583wd+TP4qyhjhJasCbI+ru3Sjmrfgn7sfRevNgoCXSSXBsMZJS wCW5xEPH9XhMifqZVnvXMfYOtZtQxdqHRSg7uIKLZFaWe82AkxD+GmI2u0jvJoFDt1vn 5TVqZ9NlGBrgXcWShTkk3/Umn4Paomqh3lP757eOWKbq2xUJGmjAv0MM3DEJsXNdeKZD o/GH5BM/SLBXqibGW7rVSYZXnb7Pv1eosrbpawSuz0tfYHQ5g1aq8YIDNGrVWhyftBch X75g== X-Gm-Message-State: AFuF++lEBUynucY56oNnSi5iJ9KPk+uYTotJ+Pt3V08obRc5ZnRU1pul tZLMgT6H9seUdH6KZRjKDQIMyywMImkHzAKEyAPXLwv1WUaecsgLt4ix7m8IATuhfBhEhfCBMar hIPjVFw== X-Gm-Gg: AR+sD13gYP3VyVmQ6AGbOxp72J8wub+eXqLiOAXRr1H4nFog3Wrr0zhNKhYpFcSpCxI q6pWm9228Qstbz4twskdBg4QfELS2BpoyQeF+JFecvGmpN9i2DTAuGOZ1UTZRnAww0lQBuKamZx eRT/tKkhwl2C+BGdQ0gLAyrPhEVklXrYhvzH0wlsGMjdZm9ysnFcxiUjLcPYRSVRS1bCh0T3p86 3nZALOyBQGAw3uTJ7c5UQRnORtavFnUtS216QIULQKijWfciMt9xMhSPSHnK6eDRzX/EPryGE1B QF+1OyoTRMUCcfRdIbTYJ6R44VxtkQTJYqUa/ASGhoUZK8E0QY5X77ZnHaIsuo4RhzRnE6AEqFF qcq+Tc7Pk4eZL7X8JgqKC1wJjxLgASdoHH7Og/whpMK03QI98QhFZWnmiJ4k5ydk/Ge3WzkfDv2 RttnNTEtG5EV7ldBlkvxFT10XXwmP8idJUekDurn5+INqDuqEZAswTykrXK5NqlZIlN92SWWQZv sCt0A== X-Received: by 2002:a05:6830:6d50:b0:7d7:ea9f:c0f9 with SMTP id 46e09a7af769-7f77c3da0c5mr6051175a34.0.1788363763807; Wed, 02 Sep 2026 08:42:43 -0700 (PDT) Received: from bapiya (97-122-117-2.hlrn.qwest.net. [97.122.117.2]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7f74cba8a21sm2504714a34.1.2026.09.02.08.42.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Sep 2026 08:42:43 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove gdbserver_windows_process::attaching Date: Wed, 2 Sep 2026 09:42:41 -0600 Message-ID: <20260902154241.3495154-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Nothing uses the field gdbserver_windows_process::attaching. This patch removes it. --- gdbserver/win32-low.cc | 6 ------ gdbserver/win32-low.h | 2 -- 2 files changed, 8 deletions(-) diff --git a/gdbserver/win32-low.cc b/gdbserver/win32-low.cc index 13c14a7c69f..5c4505cdaf8 100644 --- a/gdbserver/win32-low.cc +++ b/gdbserver/win32-low.cc @@ -517,9 +517,6 @@ win32_process_target::create_inferior (const char *program, DWORD err; char *args = (char *) program_args.c_str (); - /* win32_wait needs to know we're not attaching. */ - windows_process.attaching = 0; - if (!program) error (_("No executable specified, specify executable to debug.\n")); @@ -609,8 +606,6 @@ win32_process_target::attach (unsigned long pid) { DebugSetProcessKillOnExit (FALSE); - /* win32_wait needs to know we're attaching. */ - windows_process.attaching = 1; do_initial_child_stuff (h, pid, 1); return 0; } @@ -988,7 +983,6 @@ get_child_debug_event (DWORD *continue_status, /* Check if GDB sent us an interrupt request. */ check_remote_input_interrupt_request (); - windows_process.attaching = 0; { process_info *proc = find_process_pid (windows_process.process_id); for (thread_info &thread : proc->thread_list ()) diff --git a/gdbserver/win32-low.h b/gdbserver/win32-low.h index 439adb84bc2..a7ef8233321 100644 --- a/gdbserver/win32-low.h +++ b/gdbserver/win32-low.h @@ -187,8 +187,6 @@ struct gdbserver_windows_process : public windows_nat::windows_process_info void fill_thread_context (windows_nat::windows_thread_info *th) override; - int attaching = 0; - /* A status that hasn't been reported to the core yet, and so win32_wait should return it next, instead of fetching the next debug event off the win32 API. */ base-commit: 49c379f8c2f8ff888b621b4a070dc1976b942577 -- 2.55.0