From: Kevin Buettner <kevinb@redhat.com>
To: gdb-patches@sourceware.org
Cc: Guinevere Larsen <guinevere@redhat.com>
Subject: Re: [PATCH] gdb/testsuite: Fix supplying a function name to gdb_continue_to_breakpoint
Date: Thu, 27 Aug 2026 20:28:30 -0700 [thread overview]
Message-ID: <20260827202830.75248f5e@f44-mesa-1> (raw)
In-Reply-To: <20260827203857.206218-1-guinevere@redhat.com>
On Thu, 27 Aug 2026 17:38:57 -0300
Guinevere Larsen <guinevere@redhat.com> wrote:
> The previous regex pattern in gdb_continue_to_breakpoint expects a
> message in one of the following forms:
> Breakpoint N, <hex address> in <function>
> Breakpoint N, <function> at <linespec>
>
> And so, checks for either the "in" or the "at" keywords before the
> user-supplied pattern. However, this means that if GDB doesn't stop
> somewhere that requires printing the address, the test can't supply
> the function name when checking for the breakpoint.
>
> This commit adds the possibility of looking just for the comma before
> the user-supplied pattern, allowing the second form of the stop
> message to also accept a function name.
Makes sense to me.
Approved-By: Kevin Buettner <kevinb@redhat.com>
prev parent reply other threads:[~2026-08-28 3:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-27 20:38 Guinevere Larsen
2026-08-28 3:28 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260827202830.75248f5e@f44-mesa-1 \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=guinevere@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox