From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ekt3J4EAkWqIywkAWB0awg (envelope-from ) for ; Thu, 27 Aug 2026 23:29:05 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BU4drt8W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2BB611E09B; Thu, 27 Aug 2026 23:29:05 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C2D031E09B for ; Thu, 27 Aug 2026 23:29:02 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 28FC94BA901A for ; Fri, 28 Aug 2026 03:29:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 28FC94BA901A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BU4drt8W Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 9CAB64BA7986 for ; Fri, 28 Aug 2026 03:28:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9CAB64BA7986 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 9CAB64BA7986 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787887717; cv=none; b=TonjZYJ+l5YOU9kWObgc7clwHvAx2g4OiXXv0awUyK2fRT24yR3AmBDWkWhgYwBw4eHWB1zAFFv6VGLmAnKZ/RmcDEWLj3P/0EAKPzwuDNmCsPEvseHSpbxizqAo8KSwWv7CmxnbHtBThdjnzEUaUt2DggG5MDVfSiRtbomrKEM= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1787887717; c=relaxed/simple; bh=xySu1jawPcZuR7mzLl1RN+AOP6t0DJNASim6wrRmSxU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=dWLacFBnjw5aE5Ia4/3C9qHsKnudZllUXCrlj89rI+1MjmJHL52g0vVoSYeq2pljFvnbRkyjP0yS8FKQKRRse3dL2hg8rCKNHVad3MvsJaNI2I5TQRIeyOsdRU//7wo5iZ4Xj2/2LKwzOJdnhbmbuw9GYWbaUnHFjJtkScLV/UQ= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BU4drt8W DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9CAB64BA7986 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1787887717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j/OkEg/XT0Kbk9YAmNaHulcG7+M8JDqkVnRMhtmdAb4=; b=BU4drt8WEGfS3uMgR46oi6wdvKC4qSp/3obrGGUW/4f+hf8kbXpDLEtA5Tno2/KFXJ56WQ Saw2O4M0iWJoPqvzMwF+0gq4sNfD4bW8EORiG8Db/Xj9KZNGmZZBlH6ijfkiyD86N6NVnt d5vLs7dY9asSwfZMkjgjU0Rd2xvrs+M= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-I2BKgrp5M1Gw1ksOslARMA-1; Thu, 27 Aug 2026 23:28:35 -0400 X-MC-Unique: I2BKgrp5M1Gw1ksOslARMA-1 X-Mimecast-MFC-AGG-ID: I2BKgrp5M1Gw1ksOslARMA_1787887714 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D9CB180ABED for ; Fri, 28 Aug 2026 03:28:34 +0000 (UTC) Received: from f44-mesa-1 (unknown [10.22.88.18]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 95DC41955F72; Fri, 28 Aug 2026 03:28:33 +0000 (UTC) Date: Thu, 27 Aug 2026 20:28:30 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Guinevere Larsen Subject: Re: [PATCH] gdb/testsuite: Fix supplying a function name to gdb_continue_to_breakpoint Message-ID: <20260827202830.75248f5e@f44-mesa-1> In-Reply-To: <20260827203857.206218-1-guinevere@redhat.com> References: <20260827203857.206218-1-guinevere@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: eZhLUnykATmDVItR4S04gzpi8yIiUwYmEdT8IpAvVbQ_1787887714 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 27 Aug 2026 17:38:57 -0300 Guinevere Larsen wrote: > The previous regex pattern in gdb_continue_to_breakpoint expects a > message in one of the following forms: > Breakpoint N, in > Breakpoint N, at > > And so, checks for either the "in" or the "at" keywords before the > user-supplied pattern. However, this means that if GDB doesn't stop > somewhere that requires printing the address, the test can't supply > the function name when checking for the breakpoint. > > This commit adds the possibility of looking just for the comma before > the user-supplied pattern, allowing the second form of the stop > message to also accept a function name. Makes sense to me. Approved-By: Kevin Buettner