Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] [gdb/testsuite] Fix two test-cases on ppc64-linux
@ 2026-08-06  8:28 Tom de Vries
  2026-08-19  8:48 ` Tom de Vries
  0 siblings, 1 reply; 2+ messages in thread
From: Tom de Vries @ 2026-08-06  8:28 UTC (permalink / raw)
  To: gdb-patches

Fix two test-cases on ppc64-linux, where the .dot prefix used in the v1 ABI
is causing a mismatch.

Tested on ppc64-linux and x86_64-linux.
---
 gdb/testsuite/gdb.ada/bp_c_mixed_case.exp | 6 +++++-
 gdb/testsuite/gdb.opt/break-on-_exit.exp  | 4 +++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp b/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
index 4dd4106649a..d428825e051 100644
--- a/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
+++ b/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
@@ -60,8 +60,12 @@ gdb_test "p <MixedCaseFunc>" \
     " = void" \
     "p <MixedCaseFunc>, in Ada"
 
+# The optional leading dot is for ppc64 v1 ABI function descriptors.
 gdb_test "p <NoDebugMixedCaseFunc>" \
-    " = {<text variable, no debug info>} $hex <NoDebugMixedCaseFunc>" \
+    [quotemeta \
+	 [string cat \
+	      {$@DECIMAL = {<text variable, no debug info>} @HEX} \
+	      { <@/[.]?/NoDebugMixedCaseFunc>}]] \
     "p <NoDebugMixedCaseFunc>, in Ada"
 
 # Try inserting a breakpoint inside a C function. Because the function's
diff --git a/gdb/testsuite/gdb.opt/break-on-_exit.exp b/gdb/testsuite/gdb.opt/break-on-_exit.exp
index fa7cd96d61d..9caa54e4ad8 100644
--- a/gdb/testsuite/gdb.opt/break-on-_exit.exp
+++ b/gdb/testsuite/gdb.opt/break-on-_exit.exp
@@ -62,4 +62,6 @@ gdb_test "info shared"
 
 # If the skip_prologue analysis of _exit is too eager, we may not hit the
 # breakpoint.
-gdb_continue_to_breakpoint "_exit" "_exit \\(\\) .*"
+# The optional leading dot is for ppc64 v1 ABI function descriptors.
+gdb_continue_to_breakpoint "_exit" \
+    [quotemeta {@/[.]?/_exit () @...}]

base-commit: f94273aeb37908c32aa26530ff56e862f0060daf
-- 
2.51.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] [gdb/testsuite] Fix two test-cases on ppc64-linux
  2026-08-06  8:28 [PATCH] [gdb/testsuite] Fix two test-cases on ppc64-linux Tom de Vries
@ 2026-08-19  8:48 ` Tom de Vries
  0 siblings, 0 replies; 2+ messages in thread
From: Tom de Vries @ 2026-08-19  8:48 UTC (permalink / raw)
  To: gdb-patches

On 8/6/26 10:28 AM, Tom de Vries wrote:
> Fix two test-cases on ppc64-linux, where the .dot prefix used in the v1 ABI
> is causing a mismatch.
> 

I've pushed this.

Thanks,
- Tom

> Tested on ppc64-linux and x86_64-linux.
> ---
>   gdb/testsuite/gdb.ada/bp_c_mixed_case.exp | 6 +++++-
>   gdb/testsuite/gdb.opt/break-on-_exit.exp  | 4 +++-
>   2 files changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp b/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
> index 4dd4106649a..d428825e051 100644
> --- a/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
> +++ b/gdb/testsuite/gdb.ada/bp_c_mixed_case.exp
> @@ -60,8 +60,12 @@ gdb_test "p <MixedCaseFunc>" \
>       " = void" \
>       "p <MixedCaseFunc>, in Ada"
>   
> +# The optional leading dot is for ppc64 v1 ABI function descriptors.
>   gdb_test "p <NoDebugMixedCaseFunc>" \
> -    " = {<text variable, no debug info>} $hex <NoDebugMixedCaseFunc>" \
> +    [quotemeta \
> +	 [string cat \
> +	      {$@DECIMAL = {<text variable, no debug info>} @HEX} \
> +	      { <@/[.]?/NoDebugMixedCaseFunc>}]] \
>       "p <NoDebugMixedCaseFunc>, in Ada"
>   
>   # Try inserting a breakpoint inside a C function. Because the function's
> diff --git a/gdb/testsuite/gdb.opt/break-on-_exit.exp b/gdb/testsuite/gdb.opt/break-on-_exit.exp
> index fa7cd96d61d..9caa54e4ad8 100644
> --- a/gdb/testsuite/gdb.opt/break-on-_exit.exp
> +++ b/gdb/testsuite/gdb.opt/break-on-_exit.exp
> @@ -62,4 +62,6 @@ gdb_test "info shared"
>   
>   # If the skip_prologue analysis of _exit is too eager, we may not hit the
>   # breakpoint.
> -gdb_continue_to_breakpoint "_exit" "_exit \\(\\) .*"
> +# The optional leading dot is for ppc64 v1 ABI function descriptors.
> +gdb_continue_to_breakpoint "_exit" \
> +    [quotemeta {@/[.]?/_exit () @...}]
> 
> base-commit: f94273aeb37908c32aa26530ff56e862f0060daf


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2026-08-19  8:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-08-06  8:28 [PATCH] [gdb/testsuite] Fix two test-cases on ppc64-linux Tom de Vries
2026-08-19  8:48 ` Tom de Vries

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox