From: Tom Tromey <tromey@adacore.com>
To: gdb-patches@sourceware.org
Cc: Tom Tromey <tromey@adacore.com>
Subject: [PATCH] Remove redundant check from check_types_equal
Date: Wed, 5 Aug 2026 13:37:23 -0600 [thread overview]
Message-ID: <20260805193723.175636-1-tromey@adacore.com> (raw)
check_types_equal compares both is_nottext and instance_flags, but the
latter includes the former, so the redundant check can be removed.
---
gdb/gdbtypes.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c
index f5c0177bff2..4b6c01910f4 100644
--- a/gdb/gdbtypes.c
+++ b/gdb/gdbtypes.c
@@ -4092,7 +4092,6 @@ check_types_equal (struct type *type1, struct type *type2,
|| type1->endianity_is_not_default () != type2->endianity_is_not_default ()
|| type1->has_varargs () != type2->has_varargs ()
|| type1->is_vector () != type2->is_vector ()
- || type1->is_nottext () != type2->is_nottext ()
|| type1->instance_flags () != type2->instance_flags ()
|| type1->num_fields () != type2->num_fields ())
return false;
base-commit: b7da195b94b423e5cfd27a14c636ffe9f7380cdd
--
2.55.0
next reply other threads:[~2026-08-05 19:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-05 19:37 Tom Tromey [this message]
2026-08-06 7:20 ` Tom de Vries
2026-08-06 9:57 ` Aktemur, Baris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260805193723.175636-1-tromey@adacore.com \
--to=tromey@adacore.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox