From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ObKVBw6Rc2raswoAWB0awg (envelope-from ) for ; Wed, 05 Aug 2026 15:37:50 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=h+Swayu3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 143531E09B; Wed, 05 Aug 2026 15:37:50 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 75D8D1E09B for ; Wed, 05 Aug 2026 15:37:49 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 396874BAE7E4 for ; Wed, 5 Aug 2026 19:37:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 396874BAE7E4 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=h+Swayu3 Received: from mail-oi1-x229.google.com (mail-oi1-x229.google.com [IPv6:2607:f8b0:4864:20::229]) by sourceware.org (Postfix) with ESMTPS id DF2354B99F6C for ; Wed, 5 Aug 2026 19:37:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DF2354B99F6C Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org DF2354B99F6C Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::229 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785958646; cv=none; b=t6NAdwQWtsbIdxT+gEMKVQjw5sLHo21C0ZVLddVafqnX48UwgDVlQ8hlK5yWBxlqjCo0j7rWkbJZ1iWDcFV4hzzIiX/BiCk2E+OLJDxLcQgqu1WTQNjJk1XkfLGwBPlz/UW6xlI0+gWN/aoPy7ngYjtvfFFarRLhe8YoTBqLNp4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785958646; c=relaxed/simple; bh=/WoZU0SrwLa8vL67lgy5pVzTXNDPfWgyKjjIVtxbuY0=; h=DKIM-Signature:From:To:Subject:Date:Message-ID:MIME-Version; b=k34Yo0bEgmQSrAiEX6Hfw/gL7TBm6uIWbi3C+HC8ePFtGXPZPi7FvxmDb6W+tupDGrbaDrNaXd7fQwRau/MxpHp5WeJGk45p5CJ5fJmgNxE3w4fNY3G8TO9Nw4Glz3l5FUw0+j/qyLCIBI+CW4EfQcKf5C86VfXJQeR0XF5HSPw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, secure) header.d=adacore.com header.i=@adacore.com header.a=rsa-sha256 header.s=google header.b=h+Swayu3 DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DF2354B99F6C Received: by mail-oi1-x229.google.com with SMTP id 5614622812f47-4955cd5da3dso552583b6e.2 for ; Wed, 05 Aug 2026 12:37:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore.com; s=google; t=1785958645; x=1786563445; darn=sourceware.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to:content-type; bh=K36XbbmX04U2svEXpECrtrSG7tFKPCDxVoZdXBBUQP8=; b=h+Swayu3czlflhCRJamhlU2Za2CF1rATZVRJbK0kiECgYvQ27w6PQaO/LJKI7oid9U +sQ9iA9UzPPG6Ml218/POxC4nR8qMWoneRSOszV6wuIGzPEb93+wOPxSuoeJx2ztrcfl mC+1Fk7E+wncMz5GxuvR45btmVSm7gg6TvAAdPbhRLpdaKTbhIJVPRsLMZvZzxf9gINz Al8WOGjnIi/I16uCWe9G9Mw2ASPmBX1UtS+gvsrbZag0iWjgOTbMvN25ZNk8NitK00V/ Lu5VQPTeoXbuwjCMxyHgEwHc8oNxWFrLtATttWPXvyVw9qipXvrAPMvINe/RwRxjzArO RhaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785958645; x=1786563445; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=K36XbbmX04U2svEXpECrtrSG7tFKPCDxVoZdXBBUQP8=; b=anCGFZMhJusDT6M6gqZwcXPlAKGzD6BY1RO+AsOlPd/mXlBoGs739mq2qn/SL55qCF n9fH80pG1kfFG+GcJD3ifG6avhmV6f3ue15rae2pF3Dp9jjmkfUh+UOw+oIBBa6Rl/OA agF3fT+tbjyYtwuEbXGFrX2cuzM2dJwuV8ZS/+2wSI18gk1/2k9Uz0fAw2T/ev2u2SI0 ca+xLUJS5eSqiyjKu9zxyCnuz4sBN9cE0up6JO/KtiiDF9VDROBz1nMBpssyi2IzHnL2 QG4G85EVD4G3SwjeU6Q5f1pP2r3F3Cydsn3ka66KHfgr5m66ALMB6kq6NL5xz6cnpNiN OHIA== X-Gm-Message-State: AOJu0Ywd/uqCWA7KCjiDizZz5lyMqv4KufUP916LsTh14g/V9ZHIRX0x JTC480zD5wfYd0zw8CduzmWONp0kTADDBPg4Qs7Sevcz3uB1LAeT1FlPtfpyCX9AhC8X0ceEHmV +oes= X-Gm-Gg: AR+sD10YqWxFfwq7NYqEe1d+chmMdreLsTxqf0DDJXs6Nze8B2kY6cvVRAFGr0bP1a3 dBOVW/SdV9zexH5D1QHZ/6YNdk5CNq5k9K9Wq9TmHZ3nkai97XA1+YPgSkmagKz/TGtmcT4KBYx JjA5KgTNudAcb5NMqRlIsmlGDyGQZMVVbiS5yrNVcD6b/kUBuAVWx+VPOKAF1c9igSaVGBZ1RwL UkAtwSsJVVaz5phY3N9Hntj8lkmuTCdY/mTk6GJJ2y2XA3NO/pRa5iTs5MwtW0X0upOctfB4Dll F5ATkEExdB0Y9/0bsZTcFmsAMLxyOyvB43RzQzYSJ9fpxShehj06u5F0/lnvkn4K2wPVQzkIbel f+ZM5kanNO6YW459r5D/IUME1IJcJJ9FVq2mH6KdhTv7wE49LvhVlNiFUtSsg/2M31IHh+TSk+T 4G+AVfrEXeZVxzk2CHx2/bx9rKXoDYJk5Ei2sfBzi298Y0RQuXY3nvEfy3/aiKGccyD2vFb+PH6 W+CplUA X-Received: by 2002:a05:6808:30a0:b0:495:f67c:d96a with SMTP id 5614622812f47-4afae0f595amr5249014b6e.12.1785958645143; Wed, 05 Aug 2026 12:37:25 -0700 (PDT) Received: from bapiya (75-166-225-82.hlrn.qwest.net. [75.166.225.82]) by smtp.gmail.com with ESMTPSA id 5614622812f47-4afae4fc68fsm2690399b6e.8.2026.08.05.12.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Aug 2026 12:37:24 -0700 (PDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Remove redundant check from check_types_equal Date: Wed, 5 Aug 2026 13:37:23 -0600 Message-ID: <20260805193723.175636-1-tromey@adacore.com> X-Mailer: git-send-email 2.55.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org check_types_equal compares both is_nottext and instance_flags, but the latter includes the former, so the redundant check can be removed. --- gdb/gdbtypes.c | 1 - 1 file changed, 1 deletion(-) diff --git a/gdb/gdbtypes.c b/gdb/gdbtypes.c index f5c0177bff2..4b6c01910f4 100644 --- a/gdb/gdbtypes.c +++ b/gdb/gdbtypes.c @@ -4092,7 +4092,6 @@ check_types_equal (struct type *type1, struct type *type2, || type1->endianity_is_not_default () != type2->endianity_is_not_default () || type1->has_varargs () != type2->has_varargs () || type1->is_vector () != type2->is_vector () - || type1->is_nottext () != type2->is_nottext () || type1->instance_flags () != type2->instance_flags () || type1->num_fields () != type2->num_fields ()) return false; base-commit: b7da195b94b423e5cfd27a14c636ffe9f7380cdd -- 2.55.0