[PATCH v2 10/11] gdb, testsuite: add kfails for step-over-process-exit.exp

[PATCH v2 10/11] gdb, testsuite: add kfails for step-over-process-exit.exp

[Mohamed Bouhaouel]

From: "Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>

When running 'gdb.threads/step-over-process-exit.exp' against a
remote target in non-stop mode, GDB fails with a "Remote
communication error" and does not display the expected
"[Inferior ... exited normally]" message.  The test passes in
all-stop mode but fails when target-non-stop is enabled.

Mark the affected assertions as kfail referencing the bug report
gdb/34142 until the underlying issue is resolved.
---
 gdb/testsuite/gdb.threads/step-over-process-exit.exp | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gdb/testsuite/gdb.threads/step-over-process-exit.exp b/gdb/testsuite/gdb.threads/step-over-process-exit.exp
index 6c98ebe3956..72d270c907a 100644
--- a/gdb/testsuite/gdb.threads/step-over-process-exit.exp
+++ b/gdb/testsuite/gdb.threads/step-over-process-exit.exp
@@ -35,6 +35,11 @@ if { [prepare_for_testing "failed to prepare" $testfile $srcfile {debug pthread}
 # thread, or "other" for the non-main thread.
 
 proc test {which} {
+    if {$which == "other"} {
+	# The failure from the first iteration prevents
+	# the second iteration to run.
+	setup_kfail "gdb/34142" "*-*-*"
+    }
     if {![runto_main]} {
 	return -1
     }
@@ -48,6 +53,7 @@ proc test {which} {
 
     set target_non_stop [is_target_non_stop]
 
+    setup_kfail "gdb/34142" "*-*-*"
     gdb_test_multiple "next" "" {
 	-re -wrap "$::inferior_exited_re normally\\\]" {
 	    pass $gdb_test_name
-- 
2.43.0

Intel Deutschland GmbH

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928

[PATCH v2 11/11] gdb, remote: implement always_non_stop_p for remote target

[Mohamed Bouhaouel]

From: "Bouhaouel, Mohamed" <mohamed.bouhaouel@intel.com>

Enable remote targets to natively operate in non-stop mode when they
announce QNonStop packet support.  This changes the default setting of
'maint set target-non-stop auto' from 'off' to 'on' for remote targets,
aligning with the Linux native target.
---
 gdb/remote.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/gdb/remote.c b/gdb/remote.c
index d66bfeb02de..14abd90c306 100644
--- a/gdb/remote.c
+++ b/gdb/remote.c
@@ -1442,6 +1442,8 @@ class remote_target : public process_stratum_target
 
   void check_binary_download (CORE_ADDR addr);
 
+  bool always_non_stop_p () override;
+
   target_xfer_status remote_write_bytes_aux (const char *header,
 					     CORE_ADDR memaddr,
 					     const gdb_byte *myaddr,
@@ -9877,6 +9879,16 @@ remote_target::check_binary_download (CORE_ADDR addr)
     }
 }
 
+/* Determine whether the remote target natively operates in non-stop mode.
+   Returns true if the target announced QNonStop support for asynchronous
+   execution and stop notifications.  */
+
+bool
+remote_target::always_non_stop_p ()
+{
+  return m_features.packet_support (PACKET_QNonStop) == PACKET_ENABLE;
+}
+
 /* Helper function to resize the payload in order to try to get a good
    alignment.  We try to write an amount of data such that the next write will
    start on an address aligned on REMOTE_ALIGN_WRITES.  */
-- 
2.43.0

Intel Deutschland GmbH

Registered Address: Dornacher Strasse 1, 85622 Feldkirchen, Germany
Tel: +49 89 991 430, www.intel.de
Managing Directors: Harry Demas, Jeffrey Schneiderman, Yin Chong Sorrell
Chairperson of the Supervisory Board: Nicole Lau
Registered Seat: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928