[PATCH] gdb/amd-dbgapi-target: drop reference to amd_dbgapi_address_class_id_t

[PATCH] gdb/amd-dbgapi-target: drop reference to amd_dbgapi_address_class_id_t

[Lancelot SIX]

The rocm-dbgapi header defines a few handle types, and the
gdb/amd-dbgapi-target.h defines some generic helpers for them
(operator== and operator!=).  Nothing in GDB uses
amd_dbgapi_address_class_id_t, and this type will be removed from the
library.

Since this is not used and will be removed in the future, remove the
definition of operator== / operator!= for amd_dbgapi_address_class_id_t.

Build tested, no visible user impact expected.

Change-Id: If4c343120633b8d5b933a5ac7e722a2ed01f8b3c
---
 gdb/amd-dbgapi-target.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/gdb/amd-dbgapi-target.h b/gdb/amd-dbgapi-target.h
index 783a5c32036..08a3ec089f7 100644
--- a/gdb/amd-dbgapi-target.h
+++ b/gdb/amd-dbgapi-target.h
@@ -31,8 +31,7 @@ namespace detail
 
 template <typename T>
 using is_amd_dbgapi_handle
-  = gdb::Or<std::is_same<T, amd_dbgapi_address_class_id_t>,
-	    std::is_same<T, amd_dbgapi_address_space_id_t>,
+  = gdb::Or<std::is_same<T, amd_dbgapi_address_space_id_t>,
 	    std::is_same<T, amd_dbgapi_architecture_id_t>,
 	    std::is_same<T, amd_dbgapi_agent_id_t>,
 	    std::is_same<T, amd_dbgapi_breakpoint_id_t>,

base-commit: 054fe087c7ed53fe987bc55353a2164bc2532d0f
-- 
2.43.0

Re: [PATCH] gdb/amd-dbgapi-target: drop reference to amd_dbgapi_address_class_id_t

[Pedro Alves]

On 2026-06-03 15:34, Lancelot SIX wrote:
> The rocm-dbgapi header defines a few handle types, and the
> gdb/amd-dbgapi-target.h defines some generic helpers for them
> (operator== and operator!=).  Nothing in GDB uses
> amd_dbgapi_address_class_id_t, and this type will be removed from the
> library.
> 
> Since this is not used and will be removed in the future, remove the
> definition of operator== / operator!= for amd_dbgapi_address_class_id_t.
> 
> Build tested, no visible user impact expected.
> 

Approved-By: Pedro Alves <pedro@palves.net>

Thanks.