Re: [PATCH] [gdb/testsuite, Tcl 9] Fix EILSEQ problems for UTF8 related tests

[Kevin Buettner <kevinb@redhat.com>]

Hi Tom,

On Tue, 26 May 2026 11:22:19 +0200
Tom de Vries <tdevries@suse.de> wrote:

> Hi Kevin,
> 
> this LGTM, so:
> 
> Reviewed-By: Tom de Vries <tdevries@suse.de>
> 
> I also reviewed this using Claude code, and there were two notes:
> - using catch for one fconfigure, but not the other two.
> - it might be a good idea to add a comment in open_logs to make it
>    explicit that unlike elsewhere, "-profile replace" isn't used.

Thanks for the reviews, both from yourself and from Claude Code.

After discussing it with my own AIs (both Claude and a local Qwen3.6
27B), I've made some documentation changes and a minor unrelated code
tweak, which should address the concerns about the use of "catch" in
one location, but not the others as well as the reason for the lack of
"-profile replace".  (I didn't want to introduce another form of Tcl
version guard in open_logs, which is why I investigated whether I
could dispense with use of "-profile replace".)  In any case, I think
it's now amply documented.

I posted a v2 here:

https://sourceware.org/pipermail/gdb-patches/2026-May/227637.html

Kevin