From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oYw/NL/3FWr5OB4AWB0awg (envelope-from ) for ; Tue, 26 May 2026 15:42:55 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WeAI1ITX; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D02D11E0A3; Tue, 26 May 2026 15:42:55 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3026C1E024 for ; Tue, 26 May 2026 15:42:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B251E4BA2E3A for ; Tue, 26 May 2026 19:42:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B251E4BA2E3A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WeAI1ITX Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id BE6074BA2E3A for ; Tue, 26 May 2026 19:42:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE6074BA2E3A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE6074BA2E3A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779824548; cv=none; b=A7W1iKWfRsnxBWrhAnkUzf7zda/1lDwOJf0zmJvOGq5Nar2fWwzB7gFqlyF6SZMqNQQaY15DKKmODDCA7dBIiG5rq+6NkV6/mzktwszdOAWQF1223W46qL1BxAqDdBj/uxBuURorX45zidTDxJ/JHwmlJW2RA+80IX6kYD9q/Zo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779824548; c=relaxed/simple; bh=dog7XXIBM/VSO5wJH6v6FkPfLPT5y6lUkZtyP9MnGOU=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Vcl+3BVtEwo2kiT3rdSHex3rkErTwFGL7M6Fq2lWrSWQzJsZHu1AsMFRSQU2e5V6bFMkqgbisWP3XcCIkvrnMemKWr2pUGZToM86b+mpuXudM/3YGhS2vk00WRVCNL/RkT9jeecf9SpvS2UVCw8/2oycnroOeM6BpROIErDCxN0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=WeAI1ITX DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE6074BA2E3A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779824548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gQLjRjkEHWpa08jfp89ZLbcMC1sVCtsiGz+lTH9RfXM=; b=WeAI1ITXgZcJHt6gwhbiNQ72io9KFTbcUhpmxC6nLwUN9AntZ3Ew3eIhnC2aW/rtkNYxyK 1d26eCIaR42tGI1fQe2IsYg3+0ekY0pXaAyZY0nV+rQUrShh1d7y3s7sNR419ib4ikErki DvGi5d1KM1CZoa4U236ARXfh74mxOsk= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-353--5MXHIDgPC-7QwbL7Ek9Ag-1; Tue, 26 May 2026 15:42:24 -0400 X-MC-Unique: -5MXHIDgPC-7QwbL7Ek9Ag-1 X-Mimecast-MFC-AGG-ID: -5MXHIDgPC-7QwbL7Ek9Ag_1779824544 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E8F6118005B5; Tue, 26 May 2026 19:42:23 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.64.64]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 39A1A19560A3; Tue, 26 May 2026 19:42:23 +0000 (UTC) Date: Tue, 26 May 2026 12:42:20 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] [gdb/testsuite, Tcl 9] Fix EILSEQ problems for UTF8 related tests Message-ID: <20260526124220.487b4e7e@f42-zbm-amd> In-Reply-To: <6032850a-7dcf-4daf-8b1e-258ab0906754@suse.de> References: <20260525051442.2805651-2-kevinb@redhat.com> <6032850a-7dcf-4daf-8b1e-258ab0906754@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Nkcs507l6dW_Qs62jRq19MRNf6g__ZoQ7JaDFmbDuWc_1779824544 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi Tom, On Tue, 26 May 2026 11:22:19 +0200 Tom de Vries wrote: > Hi Kevin, > > this LGTM, so: > > Reviewed-By: Tom de Vries > > I also reviewed this using Claude code, and there were two notes: > - using catch for one fconfigure, but not the other two. > - it might be a good idea to add a comment in open_logs to make it > explicit that unlike elsewhere, "-profile replace" isn't used. Thanks for the reviews, both from yourself and from Claude Code. After discussing it with my own AIs (both Claude and a local Qwen3.6 27B), I've made some documentation changes and a minor unrelated code tweak, which should address the concerns about the use of "catch" in one location, but not the others as well as the reason for the lack of "-profile replace". (I didn't want to introduce another form of Tcl version guard in open_logs, which is why I investigated whether I could dispense with use of "-profile replace".) In any case, I think it's now amply documented. I posted a v2 here: https://sourceware.org/pipermail/gdb-patches/2026-May/227637.html Kevin