Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: gdb-patches@sourceware.org
Subject: [PATCH v2 3/5] [gdb/symtab] Simplify assignment in lnp_state_machine::record_line
Date: Mon, 20 Apr 2026 15:46:06 +0200	[thread overview]
Message-ID: <20260420134608.2537059-4-tdevries@suse.de> (raw)
In-Reply-To: <20260420134608.2537059-1-tdevries@suse.de>

Function lnp_state_machine::record_line contains this conditional assignment:
...
  if (m_last_address != m_address)
    {
      ...
      m_last_address = m_address;
    }
...

While it's true that there's no need to update m_last_address if
m_last_address == m_address, this can be expressed much simpler using an
unconditional assignment:
...
  m_last_address = m_address;
...

Fix this by using an unconditional assignment, and moving it alongside a
similar assignment:
...
+  m_last_address = m_address;
   m_last_line = m_line;
...

Tested on x86_64-linux.
---
 gdb/dwarf2/line-program.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c
index c6e28c01d67..d821de14e76 100644
--- a/gdb/dwarf2/line-program.c
+++ b/gdb/dwarf2/line-program.c
@@ -504,12 +504,10 @@ lnp_state_machine::record_line (bool end_sequence)
   /* Track whether we have seen any IS_STMT true at m_address in case we
      have multiple line table entries all at m_address.  */
   if (m_last_address != m_address)
-    {
-      m_stmt_at_address = false;
-      m_last_address = m_address;
-    }
+    m_stmt_at_address = false;
   m_stmt_at_address |= (m_flags & LEF_IS_STMT) != 0;
 
+  m_last_address = m_address;
   m_last_line = m_line;
 }
 
-- 
2.51.0


  parent reply	other threads:[~2026-04-20 13:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 13:46 [PATCH v2 0/5] [gdb/symtab] Tweak fix-up of truncated inline function block ranges Tom de Vries
2026-04-20 13:46 ` [PATCH v2 1/5] [gdb/symtab] Rename lnp_state_machine::m_last_line to m_last_recorded_line Tom de Vries
2026-04-20 13:46 ` [PATCH v2 2/5] [gdb/symtab] Re-add lnp_state_machine::m_last_line Tom de Vries
2026-04-20 13:46 ` Tom de Vries [this message]
2026-04-20 13:46 ` [PATCH v2 4/5] [gdb/symtab] Add lnp_state_machine::m_stmt_at_last_address Tom de Vries
2026-04-20 13:46 ` [PATCH v2 5/5] [gdb/symtab] Tweak fix-up of truncated inline function block ranges Tom de Vries
2026-07-29 11:01 ` [PING][PATCH v2 0/5] " Tom de Vries

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420134608.2537059-4-tdevries@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox