From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cbvdI0Iu5mkOniwAWB0awg (envelope-from ) for ; Mon, 20 Apr 2026 09:46:42 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZXqffCpU; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=//ltnq1v; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZXqffCpU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=//ltnq1v; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 8DBAB1E0BA; Mon, 20 Apr 2026 09:46:42 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D34271E0B1 for ; Mon, 20 Apr 2026 09:46:40 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 646834B35883 for ; Mon, 20 Apr 2026 13:46:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 646834B35883 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZXqffCpU; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=//ltnq1v; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=ZXqffCpU; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=//ltnq1v Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 5267D4BA23C9 for ; Mon, 20 Apr 2026 13:46:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5267D4BA23C9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5267D4BA23C9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776692770; cv=none; b=bewQSwlb9qYysX4DJDWqZiVPweyc+C7hMpNw3b7s/kirDu9sSNdK42u4J31Z6DF6nHP9/dTF1EE8xiEkdsUKWro7OQE5e63zMB1NKjqKVBybkVJtS0uopiHkpwdSw/syJku8eswtG+l85fm0Sv74qgu/VOmt96gJnqFMuyuNt6M= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776692770; c=relaxed/simple; bh=s69BUWYc/6f/kDcBm5QYNcFnKG9dlrSeApnkL5Ts2jU=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:From: To:Subject:Date:Message-ID:MIME-Version; b=awFVjviHK0wXK2wactarV6borQOrBM+MLEAgd6akfehneZR3t/CgUKeVCeyvEwubP1dPEGLbjiVqS/FZNP76sUZ/73tDWth/QaigLjmSBIOYFSoAbjDJQvitNIkGWUR6rlMLiRBkmyqiVsyMIlMB6sApT1D/FovSJ5CG4eOng2Y= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5267D4BA23C9 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 323616A7DC for ; Mon, 20 Apr 2026 13:46:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776692769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Q45KDxrTQIsQL/eCsL4Bisv83rzU4hylo0CcuuyrXU=; b=ZXqffCpUoIBNG0QkTK2gN6vasIvimYmYvU2C46Rx+qRflsbEvxjKGfDbjr1fzibYqRtdBk 9zgGGbZy+8gJYynvQbXFNi9uUdXvWA7U/Egc+GQOhVbf7ALriZidBCPEP3gg6+JkwpBiOv w3SlNm/J8bbROlE6tN7fBimQvko5G+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776692769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Q45KDxrTQIsQL/eCsL4Bisv83rzU4hylo0CcuuyrXU=; b=//ltnq1vDjcplcm5B+0Gi963INBdfAp9hFoFgxagKdMaduh+SXYXX/LwZnLnsJm2dXIW6n RWjElGDnt/mV3TBA== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=ZXqffCpU; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="//ltnq1v" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1776692769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Q45KDxrTQIsQL/eCsL4Bisv83rzU4hylo0CcuuyrXU=; b=ZXqffCpUoIBNG0QkTK2gN6vasIvimYmYvU2C46Rx+qRflsbEvxjKGfDbjr1fzibYqRtdBk 9zgGGbZy+8gJYynvQbXFNi9uUdXvWA7U/Egc+GQOhVbf7ALriZidBCPEP3gg6+JkwpBiOv w3SlNm/J8bbROlE6tN7fBimQvko5G+o= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1776692769; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8Q45KDxrTQIsQL/eCsL4Bisv83rzU4hylo0CcuuyrXU=; b=//ltnq1vDjcplcm5B+0Gi963INBdfAp9hFoFgxagKdMaduh+SXYXX/LwZnLnsJm2dXIW6n RWjElGDnt/mV3TBA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 1F6E5593AF for ; Mon, 20 Apr 2026 13:46:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id wBVlBiEu5mnzQAAAD6G6ig (envelope-from ) for ; Mon, 20 Apr 2026 13:46:09 +0000 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [PATCH v2 3/5] [gdb/symtab] Simplify assignment in lnp_state_machine::record_line Date: Mon, 20 Apr 2026 15:46:06 +0200 Message-ID: <20260420134608.2537059-4-tdevries@suse.de> X-Mailer: git-send-email 2.51.0 In-Reply-To: <20260420134608.2537059-1-tdevries@suse.de> References: <20260420134608.2537059-1-tdevries@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-3.01 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; MID_CONTAINS_FROM(1.00)[]; R_MISSING_CHARSET(0.50)[]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; URIBL_BLOCKED(0.00)[suse.de:dkim,suse.de:mid,imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; FROM_HAS_DN(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:dkim,suse.de:mid]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DNSWL_BLOCKED(0.00)[2a07:de40:b281:104:10:150:64:97:from,2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: 323616A7DC X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Function lnp_state_machine::record_line contains this conditional assignment: ... if (m_last_address != m_address) { ... m_last_address = m_address; } ... While it's true that there's no need to update m_last_address if m_last_address == m_address, this can be expressed much simpler using an unconditional assignment: ... m_last_address = m_address; ... Fix this by using an unconditional assignment, and moving it alongside a similar assignment: ... + m_last_address = m_address; m_last_line = m_line; ... Tested on x86_64-linux. --- gdb/dwarf2/line-program.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/gdb/dwarf2/line-program.c b/gdb/dwarf2/line-program.c index c6e28c01d67..d821de14e76 100644 --- a/gdb/dwarf2/line-program.c +++ b/gdb/dwarf2/line-program.c @@ -504,12 +504,10 @@ lnp_state_machine::record_line (bool end_sequence) /* Track whether we have seen any IS_STMT true at m_address in case we have multiple line table entries all at m_address. */ if (m_last_address != m_address) - { - m_stmt_at_address = false; - m_last_address = m_address; - } + m_stmt_at_address = false; m_stmt_at_address |= (m_flags & LEF_IS_STMT) != 0; + m_last_address = m_address; m_last_line = m_line; } -- 2.51.0