Re: [PATCH] gdb/testsuite: Skip gdb.base/watchpoint-adjacent.exp on s390x

[Kevin Buettner <kevinb@redhat.com>]

On Tue, 3 Mar 2026 09:56:24 +0100
Tom de Vries <tdevries@suse.de> wrote:

> On 3/3/26 3:46 AM, Kevin Buettner wrote:
> > The watchpoint-adjacent.exp test requires both read and write hardware
> > watchpoints.  s390x only supports write watchpoints, causing 108 test
> > failures when rwatch commands fail with "Target does not support this
> > type of hardware watchpoint."
> > 
> > Add a require for allow_hw_watchpoint_access_tests to skip this test on
> > architectures without read watchpoint support.  
> 
> Hi Kevin,
> 
> thanks for fixing this, LGTM.
> 
> Approved-By: Tom de Vries <tdevries@suse.de>

Thanks for the quick approval.  I've pushed it.

> BTW, it looks like this needs a similar fix:
> ...
> (gdb) rwatch data.u.size8twice[0]^M
> Target does not support this type of hardware watchpoint.^M
> (gdb) FAIL: gdb.base/watchpoint-unaligned.exp: fun=read_size8twice: 
> offset=0: index=0: rwatch data.u.size8twice[0]

Yes, I see this one too.  I'll take care of it.  Expect a patch sometime
soon...

Kevin