From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tWOSIqdWp2kG9RIAWB0awg (envelope-from ) for ; Tue, 03 Mar 2026 16:46:15 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TrjPECMK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 77AD21E0DD; Tue, 03 Mar 2026 16:46:15 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 572EF1E089 for ; Tue, 03 Mar 2026 16:46:13 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 51E224BA2E1B for ; Tue, 3 Mar 2026 21:46:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 51E224BA2E1B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=TrjPECMK Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 1A9B54BA2E0A for ; Tue, 3 Mar 2026 21:45:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1A9B54BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1A9B54BA2E0A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772574347; cv=none; b=I5IKXoJbJC1sh8Q59yckUHEmBuMFYhERoNagu3JlrIymCzOi82PBry9u1HQVXhcA//nEFErCnZ++fU28boPSgWtFUgOiJ2SgaWUz7gM3vI36krO3XnrK1A46Uw7fSMkJfr5PHc0GJooXEVDajXrliUysg3H8TO8N0eUvKpO13jY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772574347; c=relaxed/simple; bh=5cJz5gEx0nY0fjCQP+zp376JEYJUBse61eqAceY5nt8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=JKnazXz29Q/+1wjcuWOSO8sY+R2KYGNw8cDF2n4GSbUTT1V/mKvJQrXGQolGUHTyIOpWnuvo5Bm2JW0JKEwBQtdeoGWjlFv5CtzUMBfDT9u4ffNrzpM0wqJxomHVStc48Ju7YecnOGQnpZfWiy1as+DwLqZLgaH6XYGsGLtT2FM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1A9B54BA2E0A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1772574346; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZA0+x++SoVXXkIlXmGWhjTG7APGwtBMK6k3iZpIuSJk=; b=TrjPECMKbAqPzFEuNliMBkMZmnexYDRkDO3d1JHjC55NbrWs0f+hljZr8BMppIPmrDG+dk v9Z2+SVarlZfWGpR/VdmyuDC4HdLVGtjIbQ84nMTz//Kk0p1LsINt5ZjljKY5X+kKEJMIT L+P4TVuA/PQp2v721C+GywmtU4RjRCQ= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-610-5IrMmY-xM5entSewwFdLTQ-1; Tue, 03 Mar 2026 16:45:43 -0500 X-MC-Unique: 5IrMmY-xM5entSewwFdLTQ-1 X-Mimecast-MFC-AGG-ID: 5IrMmY-xM5entSewwFdLTQ_1772574343 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 82B5D195608E; Tue, 3 Mar 2026 21:45:42 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.88.47]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A62DD19560A7; Tue, 3 Mar 2026 21:45:41 +0000 (UTC) Date: Tue, 3 Mar 2026 14:45:39 -0700 From: Kevin Buettner To: Tom de Vries Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/testsuite: Skip gdb.base/watchpoint-adjacent.exp on s390x Message-ID: <20260303144539.517044b2@f42-zbm-amd> In-Reply-To: <1165cf58-be02-4303-95d2-994fcc7a2651@suse.de> References: <20260303024718.486406-1-kevinb@redhat.com> <1165cf58-be02-4303-95d2-994fcc7a2651@suse.de> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: bng_WP7t-VOB3_NIZrVcLNu2VRFwO7wkNdbalxvSwrQ_1772574343 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 3 Mar 2026 09:56:24 +0100 Tom de Vries wrote: > On 3/3/26 3:46 AM, Kevin Buettner wrote: > > The watchpoint-adjacent.exp test requires both read and write hardware > > watchpoints. s390x only supports write watchpoints, causing 108 test > > failures when rwatch commands fail with "Target does not support this > > type of hardware watchpoint." > > > > Add a require for allow_hw_watchpoint_access_tests to skip this test on > > architectures without read watchpoint support. > > Hi Kevin, > > thanks for fixing this, LGTM. > > Approved-By: Tom de Vries Thanks for the quick approval. I've pushed it. > BTW, it looks like this needs a similar fix: > ... > (gdb) rwatch data.u.size8twice[0]^M > Target does not support this type of hardware watchpoint.^M > (gdb) FAIL: gdb.base/watchpoint-unaligned.exp: fun=read_size8twice: > offset=0: index=0: rwatch data.u.size8twice[0] Yes, I see this one too. I'll take care of it. Expect a patch sometime soon... Kevin