From: Simon Marchi <simon.marchi@efficios.com>
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: [PATCH 7/8] gdb/xcoffread: replace 2 switches with if
Date: Thu, 8 Jan 2026 14:33:25 -0500 [thread overview]
Message-ID: <20260108193507.553779-8-simon.marchi@efficios.com> (raw)
In-Reply-To: <20260108193507.553779-1-simon.marchi@efficios.com>
Replace these 2 switches that have only one case with a single if
statement. It is highly unlikely that we'll ever need to check for
other values.
Change-Id: I6a48d4f27ba4d1d128aaa39d5f3d693a11e99fc9
---
gdb/xcoffread.c | 26 ++++++++++----------------
1 file changed, 10 insertions(+), 16 deletions(-)
diff --git a/gdb/xcoffread.c b/gdb/xcoffread.c
index 5494bb0debbb..5ec7281b683b 100644
--- a/gdb/xcoffread.c
+++ b/gdb/xcoffread.c
@@ -188,24 +188,18 @@ scan_xcoff_symtab (struct objfile *objfile)
else
csect_aux = main_aux[0];
- switch (csect_aux.x_csect.x_smtyp & 0x7)
+ if ((csect_aux.x_csect.x_smtyp & 0x7) == XTY_SD
+ && csect_aux.x_csect.x_smclas == XMC_TC0)
{
- case XTY_SD:
- switch (csect_aux.x_csect.x_smclas)
- {
- case XMC_TC0:
- if (toc_offset)
- warning (_("More than one XMC_TC0 symbol found."));
- toc_offset = symbol.n_value;
+ if (toc_offset)
+ warning (_("More than one XMC_TC0 symbol found."));
+ toc_offset = symbol.n_value;
- /* Make TOC offset relative to start address of
- section. */
- asection *bfd_sect
- = xcoff_secnum_to_section (symbol.n_scnum, objfile);
- if (bfd_sect)
- toc_offset -= bfd_section_vma (bfd_sect);
- break;
- }
+ /* Make TOC offset relative to start address of section. */
+ asection *bfd_sect
+ = xcoff_secnum_to_section (symbol.n_scnum, objfile);
+ if (bfd_sect)
+ toc_offset -= bfd_section_vma (bfd_sect);
break;
}
}
--
2.52.0
next prev parent reply other threads:[~2026-01-08 19:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 19:33 [PATCH 0/8] More xcoffread cleanups Simon Marchi
2026-01-08 19:33 ` [PATCH 1/8] gdb/xcoffread: remove name computation Simon Marchi
2026-01-08 20:32 ` Tom Tromey
2026-01-08 19:33 ` [PATCH 2/8] gdb/xcoffread: remove read of .debug section Simon Marchi
2026-01-08 20:32 ` Tom Tromey
2026-01-08 19:33 ` [PATCH 3/8] gdb/xcoffread: remove XCOFF_DATA macro Simon Marchi
2026-01-08 20:34 ` Tom Tromey
2026-01-08 19:33 ` [PATCH 4/8] gdb/xcoffread: remove xcoff_symfile_info::{symtbl, symtbl_num_syms} Simon Marchi
2026-01-08 20:36 ` Tom Tromey
2026-01-08 21:24 ` Simon Marchi
2026-01-08 22:17 ` Tom Tromey
2026-01-09 2:05 ` Simon Marchi
2026-01-08 19:33 ` [PATCH 5/8] gdb/xcoffread: allocate symbol table using vector in scan_xcoff_symtab Simon Marchi
2026-01-08 20:37 ` Tom Tromey
2026-01-08 19:33 ` [PATCH 6/8] gdb/xcoffread: simplify xcoff_secnum_to_sections Simon Marchi
2026-01-08 20:39 ` Tom Tromey
2026-01-08 19:33 ` Simon Marchi [this message]
2026-01-08 20:40 ` [PATCH 7/8] gdb/xcoffread: replace 2 switches with if Tom Tromey
2026-01-08 19:33 ` [PATCH 8/8] gdb/xcoffread: stylistic cleanup Simon Marchi
2026-01-08 20:41 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108193507.553779-8-simon.marchi@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox