Re: [PATCH 00/10] Rename some symtab find functions

[Kevin Buettner <kevinb@redhat.com>]

On Wed, 15 Oct 2025 20:07:54 -0400
simon.marchi@polymtl.ca wrote:

> From: Simon Marchi <simon.marchi@polymtl.ca>
> 
> I have long been confused by the names of the functions to look up
> things in symtab.  For a function named find_foo_bar, it's not obvious
> if it finds a foo from a bar or vice-versa (answer: it finds a bar for a
> given foo).  When asking around on IRC a while ago, a few people agreed.
> I'm therefore proposing to rename those functions to be of the form
> find_bar_for_foo.
> 
> Simon Marchi (10):
>   gdb: rename find_pc_function -> find_symbol_for_pc
>   gdb: rename find_pc_sect_function -> find_symbol_for_pc_sect
>   gdb: rename find_pc_sect_containing_function ->
>     find_symbol_for_pc_sect_maybe_inline
>   gdb: rename find_pc_compunit_symtab -> find_compunit_symtab_for_pc
>   gdb: rename find_pc_sect_compunit_symtab ->
>     find_compunit_symtab_for_pc_sect
>   gdb: rename find_pc_line_pc_range -> find_line_pc_range_for_pc
>   gdb: rename find_pc_line -> find_sal_for_pc
>   gdb: rename find_pc_sect_line -> find_sal_for_pc_sect
>   gdb: rename find_pc_line_symtab -> find_symtab_for_pc
>   gdb: rename find_line_pc_range -> find_pc_range_for_sal

I wholeheartedly approve of these name changes.  Over the years, I've
been confused by these names too.

Approved-by: Kevin Buettner <kevinb@redhat.com>