From: simon.marchi@polymtl.ca
To: gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: [PATCH 03/10] gdb: rename find_pc_sect_containing_function -> find_symbol_for_pc_sect_maybe_inline
Date: Wed, 15 Oct 2025 20:07:57 -0400 [thread overview]
Message-ID: <20251016001154.3969223-4-simon.marchi@polymtl.ca> (raw)
In-Reply-To: <20251016001154.3969223-1-simon.marchi@polymtl.ca>
From: Simon Marchi <simon.marchi@polymtl.ca>
Use the suffix "maybe_inline" to differentiate it from
find_symbol_for_pc_sect. find_symbol_for_pc_sect_maybe_inline can
return symbols for inline functions, while find_symbol_for_pc_sect
doesn't.
Change-Id: I6c4ef961383429ee26c8fcc0cc5df2e4e1e24959
---
gdb/blockframe.c | 2 +-
gdb/infcmd.c | 2 +-
gdb/linespec.c | 2 +-
gdb/symtab.c | 2 +-
gdb/symtab.h | 2 +-
5 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/gdb/blockframe.c b/gdb/blockframe.c
index 9374cb15184f..434208c7e269 100644
--- a/gdb/blockframe.c
+++ b/gdb/blockframe.c
@@ -153,7 +153,7 @@ find_symbol_for_pc (CORE_ADDR pc)
/* See symtab.h. */
struct symbol *
-find_pc_sect_containing_function (CORE_ADDR pc, struct obj_section *section)
+find_symbol_for_pc_sect_maybe_inline (CORE_ADDR pc, struct obj_section *section)
{
const block *bl = block_for_pc_sect (pc, section);
diff --git a/gdb/infcmd.c b/gdb/infcmd.c
index 7747f03b63b2..bb929240978f 100644
--- a/gdb/infcmd.c
+++ b/gdb/infcmd.c
@@ -1093,7 +1093,7 @@ jump_command (const char *arg, int from_tty)
/* See if we are trying to jump to another function. */
fn = get_frame_function (get_current_frame ());
- sfn = find_pc_sect_containing_function (sal.pc,
+ sfn = find_symbol_for_pc_sect_maybe_inline (sal.pc,
find_pc_mapped_section (sal.pc));
if (fn != nullptr && sfn != fn)
{
diff --git a/gdb/linespec.c b/gdb/linespec.c
index fe1fb4c07fb9..b6fe4e170bf3 100644
--- a/gdb/linespec.c
+++ b/gdb/linespec.c
@@ -2165,7 +2165,7 @@ convert_address_location_to_sals (struct linespec_state *self,
sal.pc = address;
sal.section = find_pc_overlay (address);
sal.explicit_pc = 1;
- sal.symbol = find_pc_sect_containing_function (sal.pc, sal.section);
+ sal.symbol = find_symbol_for_pc_sect_maybe_inline (sal.pc, sal.section);
std::vector<symtab_and_line> sals;
add_sal_to_sals (self, sals, sal, core_addr_to_string (address), true);
diff --git a/gdb/symtab.c b/gdb/symtab.c
index 386107451be3..100e7dbbda14 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -3565,7 +3565,7 @@ find_function_start_sal (CORE_ADDR func_addr, bool funfirstline)
/* find_function_start_sal_1 does a linetable search, so it finds
the symtab and linenumber, but not a symbol. Fill in the
function symbol too. */
- sal.symbol = find_pc_sect_containing_function (sal.pc, sal.section);
+ sal.symbol = find_symbol_for_pc_sect_maybe_inline (sal.pc, sal.section);
return sal;
}
diff --git a/gdb/symtab.h b/gdb/symtab.h
index 5d64e2149c0f..f6f25a62d2c4 100644
--- a/gdb/symtab.h
+++ b/gdb/symtab.h
@@ -2218,7 +2218,7 @@ extern struct symbol *find_symbol_for_pc_sect (CORE_ADDR, struct obj_section *);
section. The return value will be the closest enclosing function,
which might be an inline function. */
-extern struct symbol *find_pc_sect_containing_function
+extern struct symbol *find_symbol_for_pc_sect_maybe_inline
(CORE_ADDR pc, struct obj_section *section);
/* Find the symbol at the given address. Returns NULL if no symbol
--
2.51.0
next prev parent reply other threads:[~2025-10-16 0:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 0:07 [PATCH 00/10] Rename some symtab find functions simon.marchi
2025-10-16 0:07 ` [PATCH 01/10] gdb: rename find_pc_function -> find_symbol_for_pc simon.marchi
2025-10-16 0:07 ` [PATCH 02/10] gdb: rename find_pc_sect_function -> find_symbol_for_pc_sect simon.marchi
2025-10-16 0:07 ` simon.marchi [this message]
2025-10-16 0:07 ` [PATCH 04/10] gdb: rename find_pc_compunit_symtab -> find_compunit_symtab_for_pc simon.marchi
2025-10-16 0:07 ` [PATCH 05/10] gdb: rename find_pc_sect_compunit_symtab -> find_compunit_symtab_for_pc_sect simon.marchi
2025-10-16 0:08 ` [PATCH 06/10] gdb: rename find_pc_line_pc_range -> find_line_pc_range_for_pc simon.marchi
2025-10-16 0:08 ` [PATCH 07/10] gdb: rename find_pc_line -> find_sal_for_pc simon.marchi
2025-10-16 0:08 ` [PATCH 08/10] gdb: rename find_pc_sect_line -> find_sal_for_pc_sect simon.marchi
2025-10-16 0:08 ` [PATCH 09/10] gdb: rename find_pc_line_symtab -> find_symtab_for_pc simon.marchi
2025-10-16 0:08 ` [PATCH 10/10] gdb: rename find_line_pc_range -> find_pc_range_for_sal simon.marchi
2025-10-19 4:07 ` [PATCH 00/10] Rename some symtab find functions Kevin Buettner
2025-10-20 19:41 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251016001154.3969223-4-simon.marchi@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox