Re: [PATCH] Remove uses of "eval" from gdb testsuite

[Kevin Buettner <kevinb@redhat.com>]

On Mon, 15 Sep 2025 12:39:49 -0600
Tom Tromey <tom@tromey.com> wrote:

> >> proc dap_match_values {name d args} {
> >> foreach {key value} $args {
> >> -	if {[eval dict get [list $d] $key] != $value} {
> >> +	if {[dict get $d {*}$key] != $value} {  
> 
> Kevin> Is the {*} expansion needed here?  I've looked at the callers of
> Kevin> dap_match_values and the key is always a plain string, so the splatted
> Kevin> version is equivalent to 'dict get $d $key'.  The splat would only
> Kevin> matter if 'key' could be a list for a nested dictionary lookup.  
> 
> Yeah, many invocations use this feature, e.g.:
> 
> dap_match_values "argc in function" [lindex $obj 0] \
>     "body result" 3
> 
> Here 'args' ends up as the list {"body result" 3} and then the first
> call to "dict get" is passed "body result" as the key -- but this is
> trying to fetch a sub-key.

Ah, okay.  I clearly didn't look closely enough.  Thanks for the
explanation.

Reviewed-by: Kevin Buettner <kevinb@redhat.com>

Kevin