Re: [PATCH] Remove uses of "eval" from gdb testsuite

[Kevin Buettner <kevinb@redhat.com>]

On Sat, 13 Sep 2025 13:40:15 -0600
Tom Tromey <tom@tromey.com> wrote:

> This patch removes a lot of uses of the Tcl "eval" proc from the gdb
> test suite.  In most cases the {*} "splat" expansion is used instead.
> 
> A few uses of eval remain, primarily ones that were more complicated
> to untangle.
> 
> In a couple of tests I also replaced some ad hoc code with
> string_to_regexp.

I've looked it over. LGTM, though I do have one question...

> diff --git a/gdb/testsuite/lib/dap-support.exp
> b/gdb/testsuite/lib/dap-support.exp index d61b1c47f3c..3f0f75ab0ba 100644
> --- a/gdb/testsuite/lib/dap-support.exp
> +++ b/gdb/testsuite/lib/dap-support.exp
> @@ -443,7 +443,7 @@ proc dap_search_output {name rx events} {
>  # key/value pairs given in ARGS.  NAME is used as the test name.
>  proc dap_match_values {name d args} {
>      foreach {key value} $args {
> -	if {[eval dict get [list $d] $key] != $value} {
> +	if {[dict get $d {*}$key] != $value} {

Is the {*} expansion needed here?  I've looked at the callers of
dap_match_values and the key is always a plain string, so the splatted
version is equivalent to 'dict get $d $key'.  The splat would only
matter if 'key' could be a list for a nested dictionary lookup.

Kevin