Re: [PATCH] gdb: new maintenance command to help debug remote argument issues

[Kevin Buettner <kevinb@redhat.com>]

On Fri, 12 Sep 2025 17:06:21 +0100
Andrew Burgess <aburgess@redhat.com> wrote:

> Add a new maintenance command 'maint test-remote-args', this command
> takes an argument string and splits it using gdb::remote_args::split
> and then joins the result using gdb::remote_args::join and prints all
> of the results.  This is useful for diagnosing problems with remote
> argument passing.
> 
> This new command is identical to what the remote argument self-tests
> do, but while I was working on improving remote argument passing it
> was far easier to have a command that I could just throw example
> strings at, rather than having to add new selftests and recompile
> GDB.
> 
> I ended up adding a couple of additional helper functions to the
> gdb::argv_vec class.
> 
> Reviewed-By: Eli Zaretskii <eliz@gnu.org>
> Tested-By: Guinevere Larsen <guinevere@redhat.com>
> ---
>  gdb/NEWS                                      |  6 ++
>  gdb/doc/gdb.texinfo                           | 20 +++++++
>  gdb/remote.c                                  | 60 +++++++++++++++++++
>  .../gdb.base/maint-test-remote-args.exp       | 40 +++++++++++++
>  gdbsupport/gdb_argv_vec.h                     | 15 +++++
>  5 files changed, 141 insertions(+)
>  create mode 100644 gdb/testsuite/gdb.base/maint-test-remote-args.exp

LGTM.

Approved-By: Kevin Buettner <kevinb@redhat.com>