From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id FEjTI2KzxGgtEwIAWB0awg (envelope-from ) for ; Fri, 12 Sep 2025 19:57:22 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ih7kuxGu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 81C8C1E047; Fri, 12 Sep 2025 19:57:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=no autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CBB5D1E047 for ; Fri, 12 Sep 2025 19:57:20 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2A5123857B8F for ; Fri, 12 Sep 2025 23:57:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2A5123857B8F Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=ih7kuxGu Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 4CE9D3858D21 for ; Fri, 12 Sep 2025 23:56:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4CE9D3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 4CE9D3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757721410; cv=none; b=MHbh4PpZzs7XHCNd6yGSgms8sj/G/dCoNrd+H7YQlpmCMJhwecychAmco29nLG1WOLUFbeQ2JqKFVo9zF/2v8lodU7Pu2ESBwySezXNCBwRwGWCJ2EM7xtXQFXKUOusq5GWGtCtlMLYRE4zS8amdrUpPYacrNq5tr13Jlwcl/Yc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757721410; c=relaxed/simple; bh=rMYODyvTFh747oU6kKeDag0YwA8ZVEz35BLsDVx9NDs=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Y//26YK7R0LCtJRJPpGlflFkIAtX7cGG6gYb/9juYkKTTFDuBDNz646X+mQvVwJXUUxvC/fusb2J/Iced2nyPvW9DI23/8OCidyYx4sjwIYe6KR3IFhDf/04XX3HdI3FLxnM8p6j1Kqo7fmHs+UaKPUNJ9q0NuXMk5o8JRH/eF0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4CE9D3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757721410; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=6w4dP0gldm5uqiIG0kBEk7+LnhA8JKdjV5HHi3P7Jig=; b=ih7kuxGu7L9jFLKq7LwniWpDndOBGSS3JHlOuqm2PLkqC79K6f96tNRIkQxmGoJ2/i8kAr 5Pik97DWOG7s/1xYuycTF2fj4tKgA2LOHo+Yi9/rcl5FGroxAB9Z+8nsIJvft7b9ldGdq7 W1nMk4Bj9Cz03lGG9oLmb2vVAGo9aIk= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-125-sKOrGpFAMoO_AxM5HprxkA-1; Fri, 12 Sep 2025 19:56:48 -0400 X-MC-Unique: sKOrGpFAMoO_AxM5HprxkA-1 X-Mimecast-MFC-AGG-ID: sKOrGpFAMoO_AxM5HprxkA_1757721408 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DC44619560B3 for ; Fri, 12 Sep 2025 23:56:47 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.10]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 13C3F19560B9; Fri, 12 Sep 2025 23:56:46 +0000 (UTC) Date: Fri, 12 Sep 2025 16:56:41 -0700 From: Kevin Buettner To: gdb-patches@sourceware.org Cc: Andrew Burgess Subject: Re: [PATCH] gdb: new maintenance command to help debug remote argument issues Message-ID: <20250912165641.7a5b1512@f41-zbm-amd> In-Reply-To: References: Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: U0LYZIcz7FDEE90GMXPnKwCx6YUOZqaqU8o06WfeNUg_1757721408 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Fri, 12 Sep 2025 17:06:21 +0100 Andrew Burgess wrote: > Add a new maintenance command 'maint test-remote-args', this command > takes an argument string and splits it using gdb::remote_args::split > and then joins the result using gdb::remote_args::join and prints all > of the results. This is useful for diagnosing problems with remote > argument passing. > > This new command is identical to what the remote argument self-tests > do, but while I was working on improving remote argument passing it > was far easier to have a command that I could just throw example > strings at, rather than having to add new selftests and recompile > GDB. > > I ended up adding a couple of additional helper functions to the > gdb::argv_vec class. > > Reviewed-By: Eli Zaretskii > Tested-By: Guinevere Larsen > --- > gdb/NEWS | 6 ++ > gdb/doc/gdb.texinfo | 20 +++++++ > gdb/remote.c | 60 +++++++++++++++++++ > .../gdb.base/maint-test-remote-args.exp | 40 +++++++++++++ > gdbsupport/gdb_argv_vec.h | 15 +++++ > 5 files changed, 141 insertions(+) > create mode 100644 gdb/testsuite/gdb.base/maint-test-remote-args.exp LGTM. Approved-By: Kevin Buettner