Re: [PATCH v2] Fix unwinding when restoring a register from one of a greater size

[Kevin Buettner <kevinb@redhat.com>]

On Wed, 03 Sep 2025 14:08:50 +0100
Andrew Burgess <aburgess@redhat.com> wrote:

> > diff --git a/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp
> > b/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp new file
> > mode 100644 index 00000000000..32db95fa4fe
> > --- /dev/null
> > +++ b/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp
> > @@ -0,0 +1,45 @@
> > +# Copyright 2025 Free Software Foundation, Inc.
> > +
> > +# This program is free software; you can redistribute it and/or modify
> > +# it under the terms of the GNU General Public License as published by
> > +# the Free Software Foundation; either version 3 of the License, or
> > +# (at your option) any later version.
> > +#
> > +# This program is distributed in the hope that it will be useful,
> > +# but WITHOUT ANY WARRANTY; without even the implied warranty of
> > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> > +# GNU General Public License for more details.
> > +#
> > +# You should have received a copy of the GNU General Public License
> > +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
> > +
> > +require is_aarch64_target
> > +
> > +standard_testfile .c  
> 
> .c is the default, so this is usually dropped.
> 
> > +
> > +if { [prepare_for_testing "failed to prepare" ${testfile} \
> > +	"${srcfile}" {debug}] } {
> > +    return -1  
> 
> The '-1' return value here is meaningless, could you remove it please.
> 
> > +}
> > +
> > +clean_restart ${binfile}  
> 
> prepare_for_testing already includes a call to clean_restart passing in
> binfile, so this line should be removed.
> 
> > +
> > +if {![runto_main]} {
> > +    return
> > +}
> > +
> > +gdb_breakpoint [gdb_get_line_number "break-here"]
> > +gdb_continue_to_breakpoint "break-here"
> > +
> > +gdb_test_multiple "return -1" "return value -1" {
> > +    -re "Make .* return now.*y or n. $" {
> > +	send_gdb "y\n"
> > +	exp_continue
> > +    }
> > +    -re ".*result = test_function.*$gdb_prompt $" {
> > +	# pass without comment
> > +    }
> > +}  
> 
> Optionally, you could simplify this test to:
> 
>   gdb_test "with confirm off -- return -1" "result = test_function
> \\(\\);"
> 
> If you don't like the use of 'with', then you should consider using:
> 
>   -re -wrap ".*result = test_function \\(\\);" {
>     ...
>   }
> 
> But I do prefer the 'with' approach myself.
> 
> I believe that all these comments also apply to the x86 version of the
> test too.
> 
> But with these fixed:
> 
> Approved-By: Andrew Burgess <aburgess@redhat.com>

Thanks, Andrew.

I've made those changes (to both files) and have pushed this commit.

Kevin