From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sB09B1A4wmgLlT8AWB0awg (envelope-from ) for ; Wed, 10 Sep 2025 22:47:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jHIVMNga; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 080841E047; Wed, 10 Sep 2025 22:47:44 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2FF841E047 for ; Wed, 10 Sep 2025 22:47:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7950D3858D26 for ; Thu, 11 Sep 2025 02:47:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7950D3858D26 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=jHIVMNga Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 096053858D26 for ; Thu, 11 Sep 2025 02:46:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 096053858D26 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 096053858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757558816; cv=none; b=Fx98+Wohqp8VjTmGulsWaNzj2X+4osb9XSy5f6uiCHy008j+JAl0XSCA5cL4dGHG25kAlO2FLYaJsBFMfA/9hdjvRA4YW3Fzjp0VMqiy0Z+u1lNGHEDaidxOxm/7sKWkhPgbvXQ0tn+mtyto5dCVOjhdNSpxH5xyLKesQfkZIAs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757558816; c=relaxed/simple; bh=bNhKmGapKBi8T8sDGk5+VFVqAzD59z33FGx8HPkvltQ=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=LuqqwS/gdP+QiiW0TasGDxaVx3du6GxaNrgcFELHjhMr6hacYjSE5W/0sYKt//c0vhC3Q3qkcSspMLBJ1M8+qmCxKwOufaLZcixPLR0B7rDtYXP/H7CDGAOjyQKFVO8mny5pz/xSzPZOqlfMPBR8rwfZrdlz1OhcZZjXsJOHeAk= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 096053858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1757558815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0UthI/lXDBF+53m43/strSv2c/usNlx5EFR8iv8WAjE=; b=jHIVMNgaqv3spo3IKZlKMvaHInrau4XxdK9VBrxhmLVBrFRn3ToQ/55Cbah+mwvpvVmAi3 wWDfa85T5Dkd6smiT9u3za22dXAdHvjHUHXiPWN76ghs3beTTu5qb4JlA+99j/eVTiL/BB +9aLIBZfZc64oJEolXKan+a8gHn7tYY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-203-hIR0VAsiOeOvczQkBPsBaA-1; Wed, 10 Sep 2025 22:46:54 -0400 X-MC-Unique: hIR0VAsiOeOvczQkBPsBaA-1 X-Mimecast-MFC-AGG-ID: hIR0VAsiOeOvczQkBPsBaA_1757558813 Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 98D0419560B7 for ; Thu, 11 Sep 2025 02:46:53 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.10]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7A38C1800446; Thu, 11 Sep 2025 02:46:52 +0000 (UTC) Date: Wed, 10 Sep 2025 19:46:42 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCH v2] Fix unwinding when restoring a register from one of a greater size Message-ID: <20250910194642.29b1e64f@f41-zbm-amd> In-Reply-To: <87ecsnptst.fsf@redhat.com> References: <20250810043552.1096935-1-kevinb@redhat.com> <87ecsnptst.fsf@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: TkFWsL9j0XzsCEhqU6nGOIm5S-sPLHOZliYoef3be_Y_1757558813 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 03 Sep 2025 14:08:50 +0100 Andrew Burgess wrote: > > diff --git a/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp > > b/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp new file > > mode 100644 index 00000000000..32db95fa4fe > > --- /dev/null > > +++ b/gdb/testsuite/gdb.arch/aarch64-frameptr-vecreg-unwind.exp > > @@ -0,0 +1,45 @@ > > +# Copyright 2025 Free Software Foundation, Inc. > > + > > +# This program is free software; you can redistribute it and/or modify > > +# it under the terms of the GNU General Public License as published by > > +# the Free Software Foundation; either version 3 of the License, or > > +# (at your option) any later version. > > +# > > +# This program is distributed in the hope that it will be useful, > > +# but WITHOUT ANY WARRANTY; without even the implied warranty of > > +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > +# GNU General Public License for more details. > > +# > > +# You should have received a copy of the GNU General Public License > > +# along with this program. If not, see . > > + > > +require is_aarch64_target > > + > > +standard_testfile .c > > .c is the default, so this is usually dropped. > > > + > > +if { [prepare_for_testing "failed to prepare" ${testfile} \ > > + "${srcfile}" {debug}] } { > > + return -1 > > The '-1' return value here is meaningless, could you remove it please. > > > +} > > + > > +clean_restart ${binfile} > > prepare_for_testing already includes a call to clean_restart passing in > binfile, so this line should be removed. > > > + > > +if {![runto_main]} { > > + return > > +} > > + > > +gdb_breakpoint [gdb_get_line_number "break-here"] > > +gdb_continue_to_breakpoint "break-here" > > + > > +gdb_test_multiple "return -1" "return value -1" { > > + -re "Make .* return now.*y or n. $" { > > + send_gdb "y\n" > > + exp_continue > > + } > > + -re ".*result = test_function.*$gdb_prompt $" { > > + # pass without comment > > + } > > +} > > Optionally, you could simplify this test to: > > gdb_test "with confirm off -- return -1" "result = test_function > \\(\\);" > > If you don't like the use of 'with', then you should consider using: > > -re -wrap ".*result = test_function \\(\\);" { > ... > } > > But I do prefer the 'with' approach myself. > > I believe that all these comments also apply to the x86 version of the > test too. > > But with these fixed: > > Approved-By: Andrew Burgess Thanks, Andrew. I've made those changes (to both files) and have pushed this commit. Kevin