From: Kevin Buettner <kevinb@redhat.com>
To: Simon Marchi <simon.marchi@efficios.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/solib-svr4: use program space from solib in find_debug_base_for_solib
Date: Wed, 9 Jul 2025 19:44:23 -0700 [thread overview]
Message-ID: <20250709194423.3080d185@f41-zbm-amd> (raw)
In-Reply-To: <20250709141848.155865-1-simon.marchi@efficios.com>
On Wed, 9 Jul 2025 10:18:46 -0400
Simon Marchi <simon.marchi@efficios.com> wrote:
> Instead of using the current global program space, I think it makes
> sense to fetch the program space from the solib. The comment for
> solib::objfile indicates that it may be nullptr (which is true), but in
> this case, the callers (all in
> svr4_iterate_over_objfiles_in_search_order) find the solib from an
> objfile, so we know that solib::objfile (the link in the opposite
> direction) is set for these solibs at this point.
Looks right to me.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-07-10 2:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-09 14:18 Simon Marchi
2025-07-10 2:44 ` Kevin Buettner [this message]
2025-07-11 15:24 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250709194423.3080d185@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox