From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HtpdFS8pb2gEPTAAWB0awg (envelope-from ) for ; Wed, 09 Jul 2025 22:45:03 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OjvrQ1uB; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 41AA71E11C; Wed, 9 Jul 2025 22:45:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B39101E0C2 for ; Wed, 9 Jul 2025 22:45:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 07074385829B for ; Thu, 10 Jul 2025 02:45:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 07074385829B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=OjvrQ1uB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 50B7E3858CD9 for ; Thu, 10 Jul 2025 02:44:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 50B7E3858CD9 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 50B7E3858CD9 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752115471; cv=none; b=ARMgp0KZvUCZLcffLhTypdSmrgB1Kvq7a2sAe6Rqh0myIyWv3SOQjoq4d5P5q6P83swvEiqYwAClkOdmhBOwUPvGC8Wis8sCsfgbUfkLlTEhPxfIL016APEEjTTZFZeY6hH7iLd6XiaplDZe9c4XNK9/ffNowgIVKFV1UggngdE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1752115471; c=relaxed/simple; bh=LwH9Ul6yCarvemOH1KrHbn9YJ+kpxb5wSWsbjEWrx6E=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=mnB49aQCo/AXKi935D+6F/IyWfz2Ddr3FuuHgUqD39t5L9cf4cEzWKj/k+Tu0OOm+Nn7XlCpjsUnBXhhwgz8vrl1q2+r20jX7l5id4QiHv+Vu6V8DQtsGZcg2ma5DfurXcBV0i0HwydFvKpvtf7YDk1pPIXGVPAul2tSkJqvTyI= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 50B7E3858CD9 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1752115470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ya5G6e3uYbn2k6mD3bJfRKVS5dTBIHSVVMzb+bIOMqo=; b=OjvrQ1uBD3REYM/nNsFaSOCNbg7hGMb7m7thON9/5koU7PtPT2joomCW9noLtObgVu7aiL RxYtmKsx1L7IO7JCKHQOWZO6HZ5erk8ClolHhXFWRivNWKLWpitLUnZqO2JBz/uxQgagzc cNJpb/akQ6Dpy4p0pTCt8MbIraca9PM= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-377-mgHzQKDHMm29sMq46NUmmw-1; Wed, 09 Jul 2025 22:44:29 -0400 X-MC-Unique: mgHzQKDHMm29sMq46NUmmw-1 X-Mimecast-MFC-AGG-ID: mgHzQKDHMm29sMq46NUmmw_1752115468 Received: from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.40]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id AC162180029E; Thu, 10 Jul 2025 02:44:28 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.64.8]) by mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id CF3D01955E9D; Thu, 10 Jul 2025 02:44:27 +0000 (UTC) Date: Wed, 9 Jul 2025 19:44:23 -0700 From: Kevin Buettner To: Simon Marchi Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/solib-svr4: use program space from solib in find_debug_base_for_solib Message-ID: <20250709194423.3080d185@f41-zbm-amd> In-Reply-To: <20250709141848.155865-1-simon.marchi@efficios.com> References: <20250709141848.155865-1-simon.marchi@efficios.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.40 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: yyhYq67G29WaxmWUlFJZlfFw3l6Bndtilw419G1vNmE_1752115468 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 9 Jul 2025 10:18:46 -0400 Simon Marchi wrote: > Instead of using the current global program space, I think it makes > sense to fetch the program space from the solib. The comment for > solib::objfile indicates that it may be nullptr (which is true), but in > this case, the callers (all in > svr4_iterate_over_objfiles_in_search_order) find the solib from an > objfile, so we know that solib::objfile (the link in the opposite > direction) is set for these solibs at this point. Looks right to me. Approved-by: Kevin Buettner