[PATCH] [gdb/testsuite] Fix gdb.arch/amd64-disp-step-avx.exp on x86_64-freebsd

[PATCH] [gdb/testsuite] Fix gdb.arch/amd64-disp-step-avx.exp on x86_64-freebsd

[Tom de Vries]

With test-case gdb.arch/amd64-disp-step-avx.exp on x86_64-freebsd I run into:
...
(gdb) continue
Continuing.

Breakpoint 3, test_rip_vex2_end () at amd64-disp-step-avx.S:35
35		nop
(gdb) FAIL: $exp: vex2: continue to test_rip_vex2_end
...

This happens while executing this bit of the test-case:
...
    # Turn "debug displaced" on to make sure a displaced step is actually
    # executed, not an inline step.
    gdb_test_no_output "set debug displaced on"

    gdb_test "continue" \
	"Continuing.*prepared successfully .*Breakpoint.*, ${test_end_label} ().*" \
	"continue to ${test_end_label}"
...

The problem is that on x86_64, displaced stepping is only supported for linux.
Consequently, the "prepared successfully" message is missing.

Fix this by requiring linux.

Tested on x86_64-freebsd.
---
 gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
index 08d73d80f82..39779827313 100644
--- a/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
+++ b/gdb/testsuite/gdb.arch/amd64-disp-step-avx.exp
@@ -19,6 +19,7 @@
 # instructions.
 
 require is_x86_64_m64_target have_avx
+require {istarget *-*-linux*}
 
 standard_testfile .S
 

base-commit: e65d831ce1aff700e8ec3a0e784fd0e195676649
-- 
2.43.0

Re: [PATCH] [gdb/testsuite] Fix gdb.arch/amd64-disp-step-avx.exp on x86_64-freebsd

[Kevin Buettner]

On Tue,  1 Jul 2025 15:00:36 +0200
Tom de Vries <tdevries@suse.de> wrote:

> Fix this by requiring linux.

LGTM.

Approved-by: Kevin Buettner <kevinb@redhat.com>