From: Kevin Buettner <kevinb@redhat.com>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/dwarf2: Add symbols for function declarations
Date: Wed, 25 Jun 2025 10:17:48 -0700 [thread overview]
Message-ID: <20250625101748.1951d04c@f41-zbm-amd> (raw)
In-Reply-To: <20250624191903.1dcfdf16@f41-zbm-amd>
On Tue, 24 Jun 2025 19:19:03 -0700
Kevin Buettner <kevinb@redhat.com> wrote:
> On Tue, 24 Jun 2025 09:12:11 -0600
> Tom Tromey <tom@tromey.com> wrote:
>
> > I didn't really read through this yet, but in general a patch to add a
> > new (non-local) full symbol that doesn't have a corresponding change to
> > the indexer seems like it will be incorrect. The issue is that lookups
> > will only work if the CU has already been expanded; and with my
> > long-suffering search-via-the-index series, the lookups will fail
> > entirely.
...
> If you think it's needed, I'll take a look, but I'd guess that if
> I add them for indexing purposes, other bits of code might have to
> be adjusted to later remove them.
I've convinced myself that there's more to be done. I'm looking
at it now...
Kevin
prev parent reply other threads:[~2025-06-25 17:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-13 4:37 Kevin Buettner
2025-06-24 15:12 ` Tom Tromey
2025-06-25 2:19 ` Kevin Buettner
2025-06-25 17:17 ` Kevin Buettner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625101748.1951d04c@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox