From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pCwpBbAvXGjV0B4AWB0awg (envelope-from ) for ; Wed, 25 Jun 2025 13:19:44 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BqVOVtz1; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 002CB1E11E; Wed, 25 Jun 2025 13:19:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 829E71E0C2 for ; Wed, 25 Jun 2025 13:19:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EE014385AC1E for ; Wed, 25 Jun 2025 17:19:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EE014385AC1E Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=BqVOVtz1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 1F9E63857350 for ; Wed, 25 Jun 2025 17:17:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1F9E63857350 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 1F9E63857350 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750871880; cv=none; b=vZjuxvxacv96pIQo4V2TIZReofgAu5euYDbDa/1VxqKLIB4+Zl6wRdBWrk+P0y+CVpILMkeWGDfqlKU577aRSNKcnYoUp0SQtvCxWGoAz5sbY7SF3iuWvoUZXNxv0fd8DmrV5q0z+ENKae27BNac31VxLRvGkHWFfmbs9DNAYhI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750871880; c=relaxed/simple; bh=Km7ecc+TSuOodIa6P5uVCKtfpBEtGWoAvZJXtsUYfws=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=q8Jpia4yDIKd8SOI+DGM8ytCf4nLvY3vtSqFt7meQK5AQ1ihJVTE4UDUgny57FGi6gQASUSKMjT7gsc0313+u/uitmoSEc4pcigTTwnQxGhbDf/FE95r1urosTWm70Fph5aSpnv3+4wmWX5HcWxRcl172zWC5/5Nr1P2Cm+kISE= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1F9E63857350 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750871879; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZGb8GKb7KuEwozpVaD3A31qIdey2H9ySCmPepqpzFto=; b=BqVOVtz13CY5SMhUIWvwPBSP7unWXOt8SUwuFxYRVGXBFrBnNSVIDZmZBUlzwgEHuxaqua q/Y9fwE3b7jgqPzZD5o5lWWJ4hRxXwdQzs0q4/6uqB5QA3yiKyDNnCqpQzVi7fQaQKk+ZV VkA8tIPHQTHsxbRCDaHxnCXer+vaNtI= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-75-6YQNT0AVP8-P08B7JC3_Pg-1; Wed, 25 Jun 2025 13:17:55 -0400 X-MC-Unique: 6YQNT0AVP8-P08B7JC3_Pg-1 X-Mimecast-MFC-AGG-ID: 6YQNT0AVP8-P08B7JC3_Pg_1750871874 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 126221956080; Wed, 25 Jun 2025 17:17:54 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.61]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 55ED5180035E; Wed, 25 Jun 2025 17:17:53 +0000 (UTC) Date: Wed, 25 Jun 2025 10:17:48 -0700 From: Kevin Buettner To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb/dwarf2: Add symbols for function declarations Message-ID: <20250625101748.1951d04c@f41-zbm-amd> In-Reply-To: <20250624191903.1dcfdf16@f41-zbm-amd> References: <20250613044224.611229-1-kevinb@redhat.com> <87frfpyy0k.fsf@tromey.com> <20250624191903.1dcfdf16@f41-zbm-amd> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: DRQa5f_RZZZsevQy3XJaYkie6QbPI4X-8htvsY8HKEk_1750871874 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Tue, 24 Jun 2025 19:19:03 -0700 Kevin Buettner wrote: > On Tue, 24 Jun 2025 09:12:11 -0600 > Tom Tromey wrote: > > > I didn't really read through this yet, but in general a patch to add a > > new (non-local) full symbol that doesn't have a corresponding change to > > the indexer seems like it will be incorrect. The issue is that lookups > > will only work if the CU has already been expanded; and with my > > long-suffering search-via-the-index series, the lookups will fail > > entirely. ... > If you think it's needed, I'll take a look, but I'd guess that if > I add them for indexing purposes, other bits of code might have to > be adjusted to later remove them. I've convinced myself that there's more to be done. I'm looking at it now... Kevin