Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Kevin Buettner <kevinb@redhat.com>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb: LoongArch: Emulate floating-point branch instructions
Date: Tue, 6 May 2025 21:30:49 -0700	[thread overview]
Message-ID: <20250506213049.1e20d76f@f42-zbm-amd> (raw)
In-Reply-To: <20250430071015.23552-1-yangtiezhu@loongson.cn>

On Wed, 30 Apr 2025 15:10:15 +0800
Tiezhu Yang <yangtiezhu@loongson.cn> wrote:

> Add bceqz and bcnez cases in loongarch_insn_is_cond_branch() and
> loongarch_next_pc() to emulate floating-point branch instructions.
> 
> Here are the references:
> 
> https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#_bceqz_bcnez
> https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#table-table-of-instruction-encoding

Thanks for including the references, above.

The encodings for the instructions that you're handling look correct
to me.

Approved-by: Kevin Buettner <kevinb@redhat.com>


  reply	other threads:[~2025-05-07  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-30  7:10 Tiezhu Yang
2025-05-07  4:30 ` Kevin Buettner [this message]
2025-05-10 13:29   ` Tiezhu Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250506213049.1e20d76f@f42-zbm-amd \
    --to=kevinb@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=yangtiezhu@loongson.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox