From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id pJMdMiniGmjxOBgAWB0awg (envelope-from ) for ; Wed, 07 May 2025 00:31:37 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HqCqDkfs; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id BF8C81E10E; Wed, 7 May 2025 00:31:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.1 required=5.0 tests=ARC_SIGNED,ARC_VALID, BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CB72D1E092 for ; Wed, 7 May 2025 00:31:34 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 76A763858C2A for ; Wed, 7 May 2025 04:31:33 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 76A763858C2A Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=HqCqDkfs Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 21A253858C98 for ; Wed, 7 May 2025 04:31:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 21A253858C98 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 21A253858C98 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746592260; cv=none; b=jcOazLz4e4z5/yjhmgjTp+vcoDhGuLKFLVTe7rVg1JkJ7d8EHOn5+QU3S/Bx3E3+TKtK3pnkINnCleaTpTcYyfZh85UqfbvxVicp5LFw1VULioGa4m0XWjU2iWTRm/VfPvrQBYC9C3v2xViksH4zJzfHye1cPClZY+u5dD/MRg4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1746592260; c=relaxed/simple; bh=SDWUDYhz8VQY5qwL19YTHzXiAR62JTB7efA9NkG+dvc=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=D+g8JjsjeGnoQt8AB/ydFEvBLLz6EEVRymtpoTEfToBZ6wNGy5mHfZDds5OO421d1lCadzhjMospMfqWfpjn3ZZgz0oFmXue5B7SzJujsSEJOB3E+R2TA3ZwbtJ9XLoiBF53STnz95y5+AWbP3PTH/M6VpIqYP8Kf9H4ieFYY54= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 21A253858C98 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1746592259; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Wg4ZR5sLxvuUBb/KWg9eyU9WauXizFOUVcYRsbrIUkw=; b=HqCqDkfseN/YeKnAqf86ErMLjlZXQbqUVf0B0JpLpjpgfyld58TKeQX3Np6fPHSHPKD3ZJ aLd/A1lHAGhvAULJssx37X6F88WdWtKzZZPgjIlgpEFOAOoAcS7H0RBCEqkqiWl4CYlrLB 4vrj+m0HeVMCazJ74n7viKxkaNWDYd4= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-Pbtbj-l7NXy1x1E-b1edzQ-1; Wed, 07 May 2025 00:30:58 -0400 X-MC-Unique: Pbtbj-l7NXy1x1E-b1edzQ-1 X-Mimecast-MFC-AGG-ID: Pbtbj-l7NXy1x1E-b1edzQ_1746592257 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 37F46195423C; Wed, 7 May 2025 04:30:57 +0000 (UTC) Received: from f42-zbm-amd (unknown [10.22.80.66]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 55BE21956096; Wed, 7 May 2025 04:30:55 +0000 (UTC) Date: Tue, 6 May 2025 21:30:49 -0700 From: Kevin Buettner To: Tiezhu Yang Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] gdb: LoongArch: Emulate floating-point branch instructions Message-ID: <20250506213049.1e20d76f@f42-zbm-amd> In-Reply-To: <20250430071015.23552-1-yangtiezhu@loongson.cn> References: <20250430071015.23552-1-yangtiezhu@loongson.cn> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: FZHjIueItYHn2KBwIQ_oft7J3SaeZcjrpNss9_g7VK4_1746592257 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 30 Apr 2025 15:10:15 +0800 Tiezhu Yang wrote: > Add bceqz and bcnez cases in loongarch_insn_is_cond_branch() and > loongarch_next_pc() to emulate floating-point branch instructions. > > Here are the references: > > https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#_bceqz_bcnez > https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html#table-table-of-instruction-encoding Thanks for including the references, above. The encodings for the instructions that you're handling look correct to me. Approved-by: Kevin Buettner