From: Kevin Buettner <kevinb@redhat.com>
To: simon.marchi@polymtl.ca
Cc: gdb-patches@sourceware.org, Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH] gdb/dwarf: add dwarf2_cu::find_die method
Date: Thu, 24 Apr 2025 14:42:39 -0700 [thread overview]
Message-ID: <20250424144239.1499ceeb@f41-zbm-amd> (raw)
In-Reply-To: <20250424203604.2351201-1-simon.marchi@polymtl.ca>
On Thu, 24 Apr 2025 16:36:02 -0400
simon.marchi@polymtl.ca wrote:
> I added this small helper method in the series I'm writing, to make
> finding a DIE by section offset a bit nicer than using the unordered_set
> methods. It doesn't have any dependencies, so I thought I would submit
> it on its own.
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2025-04-24 21:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 20:36 simon.marchi
2025-04-24 21:42 ` Kevin Buettner [this message]
2025-04-25 2:46 ` Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424144239.1499ceeb@f41-zbm-amd \
--to=kevinb@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox