From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id PC2aHn+wCmgI6wMAWB0awg (envelope-from ) for ; Thu, 24 Apr 2025 17:43:27 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Aijisuc4; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 5C8161E0C3; Thu, 24 Apr 2025 17:43:27 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DD9191E0C2 for ; Thu, 24 Apr 2025 17:43:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 748993858C50 for ; Thu, 24 Apr 2025 21:43:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 748993858C50 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Aijisuc4 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id 5D72C3858D21 for ; Thu, 24 Apr 2025 21:42:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5D72C3858D21 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5D72C3858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745530972; cv=none; b=cwX83gJYhifnd7eXwk0uOeMUXIkeUBXN0LgIeWaoNMDL7ytJamHjeW4bukARkwwr2/WgyKkfE1mbSfu+7/UQufNeLwRkNmC1YXy2gCJLxpqVdiYSb1dDNJFE0BoooWN+1aCn3SYUV3IsElF7wNz5JroFbYqahogwwGO6WbgdRFk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1745530972; c=relaxed/simple; bh=ugnDoNZ/mDC/zmfGIHbfVbK2Xa/JSSOikhFG6rj/dqg=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=MdhShqqC2OcJ3tV6OUfXOI6MyjC5K6qDIfp+RFjGbSpKoaM+yuDgnq77z2V3o1AeA3KoOowjzJ6n99wqfBjJhtIlR0yh0ddBhkXottQC2Qyc8P7SFBoBKX4MyfIzhQeyA8v9oeE927X6ZMnoQxFlozXmkUgX9+pakqFN1su9G14= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5D72C3858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1745530972; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/iG2lK/zPPtO11J48EdHJFOJnV/INL7dnPYs8JhHW74=; b=Aijisuc4sm8ofjOogEp3g4+PfLf9noa4sfH41kUJsqRsHI8ayJw/dKRBPA653wn/elHJj+ ilC9L7+ht3KXUgiIVFXipOt3oFB3PFbzP/KHlb2Ubmq7rGt+z5xjRfetc1VaIhr9jnAjsb oRC/UgnNvjQ97Hcbmb66bPxtuMY+pcI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-yzDMC_tyOV6papVcWYQILw-1; Thu, 24 Apr 2025 17:42:48 -0400 X-MC-Unique: yzDMC_tyOV6papVcWYQILw-1 X-Mimecast-MFC-AGG-ID: yzDMC_tyOV6papVcWYQILw_1745530967 Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id C07B9180034A; Thu, 24 Apr 2025 21:42:47 +0000 (UTC) Received: from f41-zbm-amd (unknown [10.22.80.67]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8BB3019560AB; Thu, 24 Apr 2025 21:42:46 +0000 (UTC) Date: Thu, 24 Apr 2025 14:42:39 -0700 From: Kevin Buettner To: simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org, Simon Marchi Subject: Re: [PATCH] gdb/dwarf: add dwarf2_cu::find_die method Message-ID: <20250424144239.1499ceeb@f41-zbm-amd> In-Reply-To: <20250424203604.2351201-1-simon.marchi@polymtl.ca> References: <20250424203604.2351201-1-simon.marchi@polymtl.ca> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2TAjP2SIcxAPXwJpbkiYHC7SdVxGse7LTMVE4EgkqoU_1745530967 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Thu, 24 Apr 2025 16:36:02 -0400 simon.marchi@polymtl.ca wrote: > I added this small helper method in the series I'm writing, to make > finding a DIE by section offset a bit nicer than using the unordered_set > methods. It doesn't have any dependencies, so I thought I would submit > it on its own. LGTM. Approved-by: Kevin Buettner