From: Charlie Jenkins <charlie@rivosinc.com>
To: jiawei <jiawei@iscas.ac.cn>, Nelson Chu <nelson@rivosinc.com>,
Charlie Jenkins <charlie@rivosinc.com>,
Jan Beulich <jbeulich@suse.com>,
Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches <gdb-patches@sourceware.org>,
Binutils <binutils@sourceware.org>
Subject: [PATCH v2 0/2] RISC-V: Fix abort when displaying data and add test
Date: Tue, 18 Feb 2025 19:35:20 -0800 [thread overview]
Message-ID: <20250218-fix_gas_abort-v2-0-14457aa7387e@rivosinc.com> (raw)
Commit 6a04e8230707 ("RISC-V: Fix display of partial instructions")
changed how objdump displays instructions. This enabled data of any size
to be dumped. riscv_disassemble_data() only supports data of size 1,
2, 4, or 8 bytes and any other number would cause an abort.
Instead of aborting when encountering one of the other values, dump the
data as ".<N>byte <val>", similar to what is done for instructions with
".insn <N>, <val>".
Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
---
Changes in v2:
- Dump arbitrary data with ".<N>byte <val>"
- Link to v1: https://lore.kernel.org/r/20250211-fix_gas_abort-v1-0-afd9730f9c51@rivosinc.com
---
Charlie Jenkins (2):
RISC-V: Fix abort when displaying .dword
RISC-V: Add testcase for 6 byte instruction
gas/testsuite/gas/riscv/dis-partial-insn-dword.d | 12 ++++++++++++
gas/testsuite/gas/riscv/dis-partial-insn-dword.s | 2 ++
gas/testsuite/gas/riscv/dis-partial-insn-word.d | 2 +-
opcodes/riscv-dis.c | 19 ++++++++++---------
4 files changed, 25 insertions(+), 10 deletions(-)
---
base-commit: f1ffed29357a30162506c0c895f2927c7c2a4aba
change-id: 20250211-fix_gas_abort-6d1e28b4ad46
--
- Charlie
next reply other threads:[~2025-02-19 3:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-19 3:35 Charlie Jenkins [this message]
2025-02-19 3:35 ` [PATCH v2 1/2] RISC-V: Fix abort when displaying .dword Charlie Jenkins
2025-02-19 3:35 ` [PATCH v2 2/2] RISC-V: Add testcase for 6 byte instruction Charlie Jenkins
2025-02-19 9:25 ` Jan Beulich
2025-02-19 17:11 ` Charlie Jenkins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250218-fix_gas_abort-v2-0-14457aa7387e@rivosinc.com \
--to=charlie@rivosinc.com \
--cc=aburgess@redhat.com \
--cc=binutils@sourceware.org \
--cc=gdb-patches@sourceware.org \
--cc=jbeulich@suse.com \
--cc=jiawei@iscas.ac.cn \
--cc=nelson@rivosinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox