From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xep+BQhTtWdC6DUAWB0awg (envelope-from ) for ; Tue, 18 Feb 2025 22:42:00 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Qay+5fDb; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 04A311E105; Tue, 18 Feb 2025 22:42:00 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C1A851E08E for ; Tue, 18 Feb 2025 22:41:58 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AB25385841E for ; Wed, 19 Feb 2025 03:41:58 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5AB25385841E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=rivosinc-com.20230601.gappssmtp.com header.i=@rivosinc-com.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=Qay+5fDb Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 7735B3858C42 for ; Wed, 19 Feb 2025 03:35:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7735B3858C42 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7735B3858C42 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::1035 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739936133; cv=none; b=XXJXPlLDCTeGq+VFyO9qayeunAdGHiq9Fzh7gjpCCbRCKp3CDfi2hmANyJSCeFE1GWOMe58bQB4ncOEvW4ri+XNkG8cGk6Nuj/3Ntu5m0YTDPsHyoA+nX9pI79HwjJDDZM+Lcq3lQEYvQG83lt2lUMIezqE4Js1PYcFvKIFtn8o= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1739936133; c=relaxed/simple; bh=I2C1Ds2ZW3xIwOcfmJT84bMogwMKtisOXOwv4GOe+zw=; h=DKIM-Signature:From:Subject:Date:Message-Id:MIME-Version:To; b=TF0p+MtMhuU91wXnl71nGgX7rH1f47KwglxpJtJoqEZnzHYoz43mtzt0+iidyeR0znuJJPrWcHjbAb4pFsw0orxAprA20P/dvmibu6xV45LBGca9E5UEPsparEpSSKOYz4zzMtdtIhcUI/PRmwLCO+zS2aJprwYozBUf+pIOYDw= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7735B3858C42 Received: by mail-pj1-x1035.google.com with SMTP id 98e67ed59e1d1-2fc4418c0b9so5119028a91.0 for ; Tue, 18 Feb 2025 19:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739936131; x=1740540931; darn=sourceware.org; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:from:to:cc:subject:date:message-id:reply-to; bh=y+xln69BElzQasrLcWNGC/7IRZdFBDj02UZXjSUkyhg=; b=Qay+5fDbKtJb8TWSXZj5SdFdaUrj3gUWIRvKAUfM+QXn/47DqxDGJjQ2Iy4DO2fTwF Bup065yQ13ID5EEYhXqlIkeo/Ii3ez5fqiRSDoAYyluSnCaRXbuXP9hLACXajdzKEPjj pVi3fMqGaOLE6ld1gAfgH6t87P5YcUOG1MeSwErc6cnDugl3s1OYRy5B14Jfyj88tPoQ bHopEuMBl9q61zlqCp3+094XvfFMAtzsB2M4iL3c79bBMBdBW1/0moL++sB2zELawT6t LWhwMtNhxt+D53lTNuF0O0/bVyN9iqjAyWD8Uov9hzhN/RHAbILwoi0xxXLbT+ZQNkE6 pfIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739936131; x=1740540931; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y+xln69BElzQasrLcWNGC/7IRZdFBDj02UZXjSUkyhg=; b=H60siQalhb/KsNd2ONxJCsa96D1i8Odkx/z8Rx2zLP8SPnrDNk8sd2zQp82knFauOj 77bMqcmLS7k91I5DYj+e/RDz6RdE66D9feQSjO3LW7p0FjX7FMaB1wJuqO4KdSIQomMS RIIzfLk+stzu1J9R00M/r31xXnUkX2UNOYcwyUCq04bexNzdvi/qhusecJGhTFGL6AUJ +GVcopRRzpxa37BB6ujzT+S8Ap/ABhS1xFL20aMgveYeCFvm6WE6IbnUtIEM5i++RxSv 5wfjp+cvfVmOoUKs0T0bH5YMW1gHujn2if+4QTyUydgJ9U+MTr5bhCnQnLZ0lZy0bMsz yXfg== X-Gm-Message-State: AOJu0YxHk+qV7MIU4+hZcv7chnKe67Z3cs32q/eV4/oZyiXN+2rwTNav QF7U/RdpUH5hGHMJXYwQPeuYBbV/97t3EqBzjY6kzJ4rAfhiwOD8Uo/epn2JbmI= X-Gm-Gg: ASbGnctf0Z4gUUWyYu3ontSkhKDNKSaJSv2Aaa/dXH7in5MkNhpdlHuQoPv2wPUxGau rZBF2x8+HOaJTC2Of7vZtjeybWvVh0zW1ICYAdP++ZuwBrapsUJkVKVduBIX15ABs5ml/AbJZab GW8u6mESFQWzv8kmLx6G/5vKR7ODq2aF/PZL9Paik7cuKKF/ZzIZjgx9aRa+/LwDsGpyF/K+nuF yLS365+RRRYo6P5d0fbLHbVi4vNR9qbmBYykWmEu1U0/jOdq9OYg10RLj7YNrE++0VwCFTzv5N/ 0ruZjFuwpwOJSD3p+924W28+aoPCR0M= X-Google-Smtp-Source: AGHT+IHMa4L/7x7/JQGX2zKJ0+HwDPtjsrou4AksGvOOgPDjL0T9EX/gR+sLDYLr/MEPy1NmznzjTw== X-Received: by 2002:a05:6a00:2406:b0:730:937f:e823 with SMTP id d2e1a72fcca58-7329df2c58dmr3296963b3a.24.1739936131332; Tue, 18 Feb 2025 19:35:31 -0800 (PST) Received: from charlie.ba.rivosinc.com ([64.71.180.162]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-73292308e2asm2220065b3a.136.2025.02.18.19.35.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Feb 2025 19:35:30 -0800 (PST) From: Charlie Jenkins Subject: [PATCH v2 0/2] RISC-V: Fix abort when displaying data and add test Date: Tue, 18 Feb 2025 19:35:20 -0800 Message-Id: <20250218-fix_gas_abort-v2-0-14457aa7387e@rivosinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-B4-Tracking: v=1; b=H4sIAHhRtWcC/3WMyw6CMBBFf4XM2ppOBRRX/ochpPQBs5CSKWk0p P9uZe/y3NxzdoiOyUW4VzuwSxQpLAXUqQIz62VygmxhUFI1UiEKT+9h0nHQY+BNtBaduo21tnU LxVnZlcPRe/aFZ4pb4M+RT/hb/5USCim0t931In1nGnwwpRBpMWcTXtDnnL+x5DzkrQAAAA== X-Change-ID: 20250211-fix_gas_abort-6d1e28b4ad46 To: jiawei , Nelson Chu , Charlie Jenkins , Jan Beulich , Andrew Burgess Cc: gdb-patches , Binutils X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1231; i=charlie@rivosinc.com; h=from:subject:message-id; bh=I2C1Ds2ZW3xIwOcfmJT84bMogwMKtisOXOwv4GOe+zw=; b=owGbwMvMwCXWx5hUnlvL8Y3xtFoSQ/rWwMon0Uz/6z26g6foJy4zkbz/fv6HW4ta2VI2s3LfX qjasuNDRykLgxgXg6yYIgvPtQbm1jv6ZUdFyybAzGFlAhnCwMUpABNhb2NkWHtEdoe3+KF517b6 yvrmrTt8vM/M60HExYauWMbkmL0XbzH8ZkuYcDpI5ZQzQ3K2/JOHP97NW/Vqi7o+R9y5r56Lzz/ 9xwQA X-Developer-Key: i=charlie@rivosinc.com; a=openpgp; fpr=7D834FF11B1D8387E61C776FFB10D1F27D6B1354 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Commit 6a04e8230707 ("RISC-V: Fix display of partial instructions") changed how objdump displays instructions. This enabled data of any size to be dumped. riscv_disassemble_data() only supports data of size 1, 2, 4, or 8 bytes and any other number would cause an abort. Instead of aborting when encountering one of the other values, dump the data as ".byte ", similar to what is done for instructions with ".insn , ". Signed-off-by: Charlie Jenkins --- Changes in v2: - Dump arbitrary data with ".byte " - Link to v1: https://lore.kernel.org/r/20250211-fix_gas_abort-v1-0-afd9730f9c51@rivosinc.com --- Charlie Jenkins (2): RISC-V: Fix abort when displaying .dword RISC-V: Add testcase for 6 byte instruction gas/testsuite/gas/riscv/dis-partial-insn-dword.d | 12 ++++++++++++ gas/testsuite/gas/riscv/dis-partial-insn-dword.s | 2 ++ gas/testsuite/gas/riscv/dis-partial-insn-word.d | 2 +- opcodes/riscv-dis.c | 19 ++++++++++--------- 4 files changed, 25 insertions(+), 10 deletions(-) --- base-commit: f1ffed29357a30162506c0c895f2927c7c2a4aba change-id: 20250211-fix_gas_abort-6d1e28b4ad46 -- - Charlie