From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, Bernd Edlinger <bernd.edlinger@hotmail.de>
Subject: Re: [PATCH] gdb: handle DW_AT_entry_pc pointing at an empty sub-range
Date: Wed, 20 Nov 2024 14:00:53 -0700 [thread overview]
Message-ID: <20241120140053.25b1624c@f40-zbm-amd> (raw)
In-Reply-To: <34cfe440ffd0e53843bfaf92494d29a6951fa9fd.1732114887.git.aburgess@redhat.com>
On Wed, 20 Nov 2024 15:01:49 +0000
Andrew Burgess <aburgess@redhat.com> wrote:
[...]
> Now, on the older versions of GDB, GDB will ignore the prescribed
I assume that you actually mean "older versions of GCC"?
> entry-pc, and will instead select a suitable default entry-pc based on
> either the block's low-pc value, or the first address of the first
> range.
>
> I have extended the gdb.cp/step-and-next-inline.exp test to check this
> case, but this does depend on the compiler version being used (newer
> compilers will always pass, even without the fix).
>
> So I have also added a DWARF assembler test to cover this case.
Thanks for the detailed explanation.
The patches LGTM.
Reviewed-by: Kevin Buettner <kevinb@redhat.com>
(If there isn't additional discussion within a week or so, please
consider the above to be Approved-by.)
next prev parent reply other threads:[~2024-11-20 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 15:01 Andrew Burgess
2024-11-20 21:00 ` Kevin Buettner [this message]
2024-11-21 13:21 ` Bernd Edlinger
2024-11-22 16:53 ` Andrew Burgess
2024-11-22 22:57 ` Bernd Edlinger
2024-11-25 14:30 ` Andrew Burgess
2024-11-26 12:35 ` Bernd Edlinger
2024-11-26 17:48 ` Andrew Burgess
2024-11-27 20:12 ` Bernd Edlinger
2024-11-28 10:10 ` Andrew Burgess
2024-11-28 17:44 ` [PATCHv2] " Andrew Burgess
2024-11-29 14:19 ` Bernd Edlinger
2024-12-02 10:53 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120140053.25b1624c@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox