From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E3gGEzVOPmdKfzgAWB0awg (envelope-from ) for ; Wed, 20 Nov 2024 16:01:41 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aChkhJ76; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 2C8461E253; Wed, 20 Nov 2024 16:01:41 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 229AE1E1CC for ; Wed, 20 Nov 2024 16:01:40 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9DFEB3858282 for ; Wed, 20 Nov 2024 21:01:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9DFEB3858282 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=aChkhJ76 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id 7BCC93858D26 for ; Wed, 20 Nov 2024 21:01:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7BCC93858D26 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7BCC93858D26 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732136464; cv=none; b=FJ1ZRTBduwbpzRnGVg/AvDXWa2eIjiihXS5sGsMilSYbWPuxuAegSidEkLMejl5/Fcj9k+IRTnrdAb8D3BqEzGLRe8ImO7lIlzUyEmcwBItIpNXAB6CGuCza377Bi1HKMQHP/qmNLY1BEcp0493h3Di/9exB/9x25udcDBLHYRA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1732136464; c=relaxed/simple; bh=jtZ6LdNRbLq/Ibemm1YaBwNtRjonExhLKUwq3NiUwRY=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=uX5m8RJRtok7P5I4Q6yGn6R8619buqLhVaUjL2mVFgBVqA+BgVdz3njm9bvOMgWxw6oIosZSQ6pd35vDpRyN4+Bi0gfSLNNjkrKHzwKHZckfpiNOVkjUNHEjigtLzxQYLRCp0+qfOUob7VuGG1nwPiFQ77nbyLWYEROMI5KNa1U= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7BCC93858D26 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732136464; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0mxT1T3ophQ3xTgBPhTELnNsVAoLAqxbzOTW/b5U9qo=; b=aChkhJ769Z1+YeIm2KBXJ94Zm5pc0BhubOQRv5jRJrwWtGIpAQRp4PYTTSdhmKpTnn1sM/ zCWh2ewrVjRsHQOF2FPcB9oe5FlUCyfmLgwsR1nclmK55SyxP4nE/MyrWmnManKS8eLtPu tP8fOHL9PtZmnqGMTbUb3K8a8E9S9Rw= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-442-Ic82O-3vPYCK7D0feJ2sbQ-1; Wed, 20 Nov 2024 16:01:03 -0500 X-MC-Unique: Ic82O-3vPYCK7D0feJ2sbQ-1 X-Mimecast-MFC-AGG-ID: Ic82O-3vPYCK7D0feJ2sbQ Received: from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 1764D19541A0; Wed, 20 Nov 2024 21:01:02 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.80.92]) by mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 0C1AE196BC17; Wed, 20 Nov 2024 21:00:57 +0000 (UTC) Date: Wed, 20 Nov 2024 14:00:53 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org, Bernd Edlinger Subject: Re: [PATCH] gdb: handle DW_AT_entry_pc pointing at an empty sub-range Message-ID: <20241120140053.25b1624c@f40-zbm-amd> In-Reply-To: <34cfe440ffd0e53843bfaf92494d29a6951fa9fd.1732114887.git.aburgess@redhat.com> References: <34cfe440ffd0e53843bfaf92494d29a6951fa9fd.1732114887.git.aburgess@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.15 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zpnwoefiUkFu1FFXqukaMZwPYEYWgIffatTTYIDHzeo_1732136462 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Wed, 20 Nov 2024 15:01:49 +0000 Andrew Burgess wrote: [...] > Now, on the older versions of GDB, GDB will ignore the prescribed I assume that you actually mean "older versions of GCC"? > entry-pc, and will instead select a suitable default entry-pc based on > either the block's low-pc value, or the first address of the first > range. > > I have extended the gdb.cp/step-and-next-inline.exp test to check this > case, but this does depend on the compiler version being used (newer > compilers will always pass, even without the fix). > > So I have also added a DWARF assembler test to cover this case. Thanks for the detailed explanation. The patches LGTM. Reviewed-by: Kevin Buettner (If there isn't additional discussion within a week or so, please consider the above to be Approved-by.)