From: Kevin Buettner <kevinb@redhat.com>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCHv5 1/3] gdb/features: set osabi in all Linux related features/*.xml files
Date: Wed, 30 Oct 2024 19:17:15 -0700 [thread overview]
Message-ID: <20241030191715.1b5f8b15@f40-zbm-amd> (raw)
In-Reply-To: <5ae0586f15def7f48516494b3529824cc552b839.1730059609.git.aburgess@redhat.com>
On Sun, 27 Oct 2024 20:07:40 +0000
Andrew Burgess <aburgess@redhat.com> wrote:
> Some of the top level (i.e. those that contain the <target> element)
> xml files in gdb/features/ are clearly Linux only. I conclude this
> based on the files names containing the string "linux".
>
> I think that all of these files should have the <osabi> element
> included with the value "GNU/Linux".
>
> This commits adds the <osabi> element where I believe it is
> appropriate and regenerates the associated .c files.
>
> The benefit of this change is that gdbserver, which makes use of these
> files, will now send the osabi back in more cases. Sending back more
> descriptive target descriptions is a good thing as this makes it
> easier for GDB to select the correct gdbarch.
LGTM.
Approved-by: Kevin Buettner <kevinb@redhat.com>
next prev parent reply other threads:[~2024-10-31 2:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 22:27 [PATCHv3 0/3] Returning osabi from gdbserer in more cases Andrew Burgess
2024-10-11 22:27 ` [PATCHv3 1/3] gdb/features: set osabi in all Linux related features/*.xml files Andrew Burgess
2024-10-11 22:27 ` [PATCHv3 2/3] gdb/regformats: add osabi information to generated .dat files Andrew Burgess
2024-10-11 22:27 ` [PATCHv3 3/3] gdbserver: pass osabi to GDB in more target descriptions Andrew Burgess
2024-10-15 14:05 ` [PATCHv4 0/3] Returning osabi from gdbserer in more cases Andrew Burgess
2024-10-15 14:05 ` [PATCHv4 1/3] gdb/features: set osabi in all Linux related features/*.xml files Andrew Burgess
2024-10-15 14:05 ` [PATCHv4 2/3] gdb/regformats: add osabi information to generated .dat files Andrew Burgess
2024-10-15 14:05 ` [PATCHv4 3/3] gdbserver: pass osabi to GDB in more target descriptions Andrew Burgess
2024-10-27 20:07 ` [PATCHv5 0/3] Returning osabi from gdbserer in more cases Andrew Burgess
2024-10-27 20:07 ` [PATCHv5 1/3] gdb/features: set osabi in all Linux related features/*.xml files Andrew Burgess
2024-10-31 2:17 ` Kevin Buettner [this message]
2024-10-27 20:07 ` [PATCHv5 2/3] gdb/regformats: add osabi information to generated .dat files Andrew Burgess
2024-10-31 2:20 ` Kevin Buettner
2024-10-27 20:07 ` [PATCHv5 3/3] gdbserver: pass osabi to GDB in more target descriptions Andrew Burgess
2024-10-31 2:28 ` Kevin Buettner
2024-10-31 9:43 ` Andrew Burgess
2024-11-12 13:46 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241030191715.1b5f8b15@f40-zbm-amd \
--to=kevinb@redhat.com \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox