From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id NCVfAtDoImeIKCAAWB0awg (envelope-from ) for ; Wed, 30 Oct 2024 22:17:52 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=A0Vl20C8; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E1F3B1E5A1; Wed, 30 Oct 2024 22:17:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1C1EF1E37A for ; Wed, 30 Oct 2024 22:17:51 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 49FF53857839 for ; Thu, 31 Oct 2024 02:17:50 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id ACB873858D21 for ; Thu, 31 Oct 2024 02:17:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ACB873858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ACB873858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730341048; cv=none; b=fQvNHA7562v3ipbkLQJm8i6yjszTA7NkhpnJm22efxDEGEsAB0M/k4U17AJ2EyWmQlxWIX1pplnyiynSCSYn07apKZVmmk91A7BuVXZcN8C5BneFEJX2ZkYTAtv3/jGYYJFxURLb3JW9IY9Z1zTIHB42hameZGQhpTSpOeOy784= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730341048; c=relaxed/simple; bh=I53lhsUFiYjwApM0znBwT+mf8RLzZaS9qpnKO637hKw=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=nbpXWei4IESvoxKo67A5UZxqCDDuFAi4wAbvVUbAUX+kmBy5MmXB6mMeWt5vBHypIuCPCT1mqHHwMhXK0hrvXmj1KptU3Bw3lBnoaO/PMqg1MD/kWouktmgldZ/XHxksBUUMlraLSwO81rg+ykoAagejPa3gIBqu7VkH29zAHFY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1730341046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nHPMQTaQLG4lkTRbn+kwuGYHwKy40OnJ4AhJj/AsfBs=; b=A0Vl20C8V+SnwvAz6rzSXSBi4R30o7n/Eh67wzsBcj54y7Jt91MkU2j9pYBr8558ma/VH1 9MqMmk9H2ffuYOXDIXr9QveVFEeKgvtb5lf1l8+89cPOlWRZ5haATqgnXrkg0W0mNj2B46 J9ixZVdzG/Gz4+ROaR6lKHvQ5KqhRr8= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-385-_xf4_HFAOIejDnEOCulZKw-1; Wed, 30 Oct 2024 22:17:22 -0400 X-MC-Unique: _xf4_HFAOIejDnEOCulZKw-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6E7F919560A2 for ; Thu, 31 Oct 2024 02:17:21 +0000 (UTC) Received: from f40-zbm-amd (unknown [10.22.64.38]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6BD121956052; Thu, 31 Oct 2024 02:17:19 +0000 (UTC) Date: Wed, 30 Oct 2024 19:17:15 -0700 From: Kevin Buettner To: Andrew Burgess Cc: gdb-patches@sourceware.org Subject: Re: [PATCHv5 1/3] gdb/features: set osabi in all Linux related features/*.xml files Message-ID: <20241030191715.1b5f8b15@f40-zbm-amd> In-Reply-To: <5ae0586f15def7f48516494b3529824cc552b839.1730059609.git.aburgess@redhat.com> References: <5ae0586f15def7f48516494b3529824cc552b839.1730059609.git.aburgess@redhat.com> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On Sun, 27 Oct 2024 20:07:40 +0000 Andrew Burgess wrote: > Some of the top level (i.e. those that contain the element) > xml files in gdb/features/ are clearly Linux only. I conclude this > based on the files names containing the string "linux". > > I think that all of these files should have the element > included with the value "GNU/Linux". > > This commits adds the element where I believe it is > appropriate and regenerates the associated .c files. > > The benefit of this change is that gdbserver, which makes use of these > files, will now send the osabi back in more cases. Sending back more > descriptive target descriptions is a good thing as this makes it > easier for GDB to select the correct gdbarch. LGTM. Approved-by: Kevin Buettner